No subject
Fri Sep 2 03:59:05 CDT 2011
/trunk/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1753/#comment10187>
As you come across passages like these, it may be worthwhile to add som=
e comments to indicate that this should be looked at again once the opaquif=
ication is completed. The reason is that there are a lot of calls to ast_ch=
annel_cdr() here, and it may be possible to call it once and set a local va=
riable, then just use the local variable for the rest of the section.
=
Please don't make such actual changes now, but "todo"-style comments ar=
e welcome.
/trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/1753/#comment10186>
If at all possible, I'd rename these two functions. The accessor sounds=
like something you would call in order to emulate a DTMF digit. The setter=
just sounds like nonsense.
- Mark
On Feb. 18, 2012, 1:45 p.m., Terry Wilson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1753/
> -----------------------------------------------------------
> =
> (Updated Feb. 18, 2012, 1:45 p.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> This converts various int/long fields and most pointer fields. That leave=
s mostly structs, typedefs, a couple of int arrays and a couple of "problem=
fields". It might be a good idea for reviewers to apply the patch and comp=
ile just in case I missed something somewhere.
> =
> =
> Diffs
> -----
> =
> /trunk/addons/chan_mobile.c 355898 =
> /trunk/addons/chan_ooh323.c 355898 =
> /trunk/apps/app_alarmreceiver.c 355898 =
> /trunk/apps/app_authenticate.c 355898 =
> /trunk/apps/app_cdr.c 355898 =
> /trunk/apps/app_chanisavail.c 355898 =
> /trunk/apps/app_channelredirect.c 355898 =
> /trunk/apps/app_chanspy.c 355898 =
> /trunk/apps/app_confbridge.c 355898 =
> /trunk/apps/app_dahdibarge.c 355898 =
> /trunk/apps/app_dahdiras.c 355898 =
> /trunk/apps/app_dial.c 355898 =
> /trunk/apps/app_dictate.c 355898 =
> /trunk/apps/app_directory.c 355898 =
> /trunk/apps/app_disa.c 355898 =
> /trunk/apps/app_dumpchan.c 355898 =
> /trunk/apps/app_echo.c 355898 =
> /trunk/apps/app_externalivr.c 355898 =
> /trunk/apps/app_fax.c 355898 =
> /trunk/apps/app_festival.c 355898 =
> /trunk/apps/app_flash.c 355898 =
> /trunk/apps/app_followme.c 355898 =
> /trunk/apps/app_forkcdr.c 355898 =
> /trunk/apps/app_ices.c 355898 =
> /trunk/apps/app_ivrdemo.c 355898 =
> /trunk/apps/app_macro.c 355898 =
> /trunk/apps/app_meetme.c 355898 =
> /trunk/apps/app_milliwatt.c 355898 =
> /trunk/apps/app_minivm.c 355898 =
> /trunk/apps/app_osplookup.c 355898 =
> /trunk/apps/app_parkandannounce.c 355898 =
> /trunk/apps/app_playback.c 355898 =
> /trunk/apps/app_playtones.c 355898 =
> /trunk/apps/app_privacy.c 355898 =
> /trunk/apps/app_queue.c 355898 =
> /trunk/apps/app_read.c 355898 =
> /trunk/apps/app_readexten.c 355898 =
> /trunk/apps/app_record.c 355898 =
> /trunk/apps/app_rpt.c 355898 =
> /trunk/apps/app_sayunixtime.c 355898 =
> /trunk/apps/app_sendtext.c 355898 =
> /trunk/apps/app_sms.c 355898 =
> /trunk/apps/app_softhangup.c 355898 =
> /trunk/apps/app_speech_utils.c 355898 =
> /trunk/apps/app_stack.c 355898 =
> /trunk/apps/app_talkdetect.c 355898 =
> /trunk/apps/app_test.c 355898 =
> /trunk/apps/app_transfer.c 355898 =
> /trunk/apps/app_verbose.c 355898 =
> /trunk/apps/app_voicemail.c 355898 =
> /trunk/apps/app_waitforsilence.c 355898 =
> /trunk/apps/app_while.c 355898 =
> /trunk/apps/app_zapateller.c 355898 =
> /trunk/bridges/bridge_builtin_features.c 355898 =
> /trunk/bridges/bridge_multiplexed.c 355898 =
> /trunk/bridges/bridge_simple.c 355898 =
> /trunk/cdr/cdr_custom.c 355898 =
> /trunk/cdr/cdr_manager.c 355898 =
> /trunk/cdr/cdr_sqlite3_custom.c 355898 =
> /trunk/cdr/cdr_syslog.c 355898 =
> /trunk/channels/chan_agent.c 355898 =
> /trunk/channels/chan_alsa.c 355898 =
> /trunk/channels/chan_bridge.c 355898 =
> /trunk/channels/chan_console.c 355898 =
> /trunk/channels/chan_dahdi.c 355898 =
> /trunk/channels/chan_gtalk.c 355898 =
> /trunk/channels/chan_h323.c 355898 =
> /trunk/channels/chan_iax2.c 355898 =
> /trunk/channels/chan_jingle.c 355898 =
> /trunk/channels/chan_local.c 355898 =
> /trunk/channels/chan_mgcp.c 355898 =
> /trunk/channels/chan_misdn.c 355898 =
> /trunk/channels/chan_multicast_rtp.c 355898 =
> /trunk/channels/chan_nbs.c 355898 =
> /trunk/channels/chan_oss.c 355898 =
> /trunk/channels/chan_phone.c 355898 =
> /trunk/channels/chan_sip.c 355898 =
> /trunk/channels/chan_skinny.c 355898 =
> /trunk/channels/chan_unistim.c 355898 =
> /trunk/channels/chan_usbradio.c 355898 =
> /trunk/channels/chan_vpb.cc 355898 =
> /trunk/channels/sig_analog.c 355898 =
> /trunk/channels/sig_pri.c 355898 =
> /trunk/channels/sig_ss7.c 355898 =
> /trunk/channels/sip/dialplan_functions.c 355898 =
> /trunk/funcs/func_callerid.c 355898 =
> /trunk/funcs/func_cdr.c 355898 =
> /trunk/funcs/func_channel.c 355898 =
> /trunk/funcs/func_jitterbuffer.c 355898 =
> /trunk/funcs/func_timeout.c 355898 =
> /trunk/include/asterisk/channel.h 355898 =
> /trunk/include/asterisk/sched.h 355898 =
> /trunk/main/abstract_jb.c 355898 =
> /trunk/main/app.c 355898 =
> /trunk/main/audiohook.c 355898 =
> /trunk/main/bridging.c 355898 =
> /trunk/main/ccss.c 355898 =
> /trunk/main/cdr.c 355898 =
> /trunk/main/cel.c 355898 =
> /trunk/main/channel.c 355898 =
> /trunk/main/channel_internal_api.c 355898 =
> /trunk/main/cli.c 355898 =
> /trunk/main/devicestate.c 355898 =
> /trunk/main/dial.c 355898 =
> /trunk/main/features.c 355898 =
> /trunk/main/file.c 355898 =
> /trunk/main/framehook.c 355898 =
> /trunk/main/image.c 355898 =
> /trunk/main/manager.c 355898 =
> /trunk/main/message.c 355898 =
> /trunk/main/pbx.c 355898 =
> /trunk/main/rtp_engine.c 355898 =
> /trunk/main/udptl.c 355898 =
> /trunk/pbx/pbx_lua.c 355898 =
> /trunk/pbx/pbx_realtime.c 355898 =
> /trunk/res/res_adsi.c 355898 =
> /trunk/res/res_agi.c 355898 =
> /trunk/res/res_calendar.c 355898 =
> /trunk/res/res_fax.c 355898 =
> /trunk/res/res_monitor.c 355898 =
> /trunk/res/res_musiconhold.c 355898 =
> /trunk/res/res_rtp_asterisk.c 355898 =
> /trunk/res/snmp/agent.c 355898 =
> =
> Diff: https://reviewboard.asterisk.org/r/1753/diff
> =
> =
> Testing
> -------
> =
> All unit tests pass. I got the same number of testsuite failures as a cle=
an checkout of trunk.
> =
> =
> Thanks,
> =
> Terry
> =
>
--===============4722371582759062148==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"https://reviewboard.asterisk.org/r/1753/">https://reviewbo=
ard.asterisk.org/r/1753/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From what =
I saw, I did not see any issues that prevent this from going in.</pre>
<br />
<div>
<table width=3D"100%" border=3D"0" bgcolor=3D"white" style=3D"border: 1px s=
olid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan=3D"4" bgcolor=3D"#F0F0F0" style=3D"border-bottom: 1px solid =
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href=3D"https://reviewboard.asterisk.org/r/1753/diff/1/?file=3D24343=
#file24343line523" style=3D"color: black; font-weight: bold; text-decoratio=
n: underline;">/trunk/apps/app_followme.c</a>
<span style=3D"font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style=3D"background-color: #e4d9cb; padding: 4px 8px; text-align: c=
enter;">
<tr>
<td colspan=3D"4"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; ">static void clear_caller(struct findme_user *tmpuser)</pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">523</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"k">if</span> <span class=3D"p=
">(</span><span class=3D"o">!</span><span class=3D"n">outbound</span><span =
class=3D"o"><span class=3D"hl">-></span></span><span class=3D"n"><span c=
lass=3D"hl">cdr</span></span><span class=3D"p">)</span> <span class=3D"p">{=
</span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">523</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"k">if</span> <span class=3D"p=
">(</span><span class=3D"o">!</span><span class=3D"n"><span class=3D"hl">as=
t_channel_cdr</span></span><span class=3D"p"><span class=3D"hl">(</span></s=
pan><span class=3D"n">outbound</span><span class=3D"p"><span class=3D"hl">)=
</span>)</span> <span class=3D"p">{</span></pre></td>
</tr>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">524</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">outbound</span><span clas=
s=3D"o"><span class=3D"hl">-></span></span><span class=3D"n"><span class=
=3D"hl">cdr</span></span><span class=3D"hl"> </span><span class=3D"o"><span=
class=3D"hl">=3D</span></span> <span class=3D"n">ast_cdr_alloc</span><span=
class=3D"p">();</span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">524</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n"><span class=3D"hl">ast_ch=
annel_cdr_set</span></span><span class=3D"p"><span class=3D"hl">(</span></s=
pan><span class=3D"n">outbound</span><span class=3D"p"><span class=3D"hl">,=
</span></span> <span class=3D"n">ast_cdr_alloc</span><span class=3D"p">()<s=
pan class=3D"hl">)</span>;</span></pre></td>
</tr>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">525</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"k">if</span> <span class=3D"=
p">(</span><span class=3D"n">outbound</span><span class=3D"o"><span class=
=3D"hl">-></span></span><span class=3D"n"><span class=3D"hl">cdr</span><=
/span><span class=3D"p">)</span> <span class=3D"p">{</span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">525</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"k">if</span> <span class=3D"=
p"><span class=3D"hl">(</span></span><span class=3D"n"><span class=3D"hl">a=
st_channel_cdr</span></span><span class=3D"p">(</span><span class=3D"n">out=
bound</span><span class=3D"p"><span class=3D"hl">)</span>)</span> <span cla=
ss=3D"p">{</span></pre></td>
</tr>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">526</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_init</span><span=
class=3D"p">(</span><span class=3D"n">outbound</span><span class=3D"o"><sp=
an class=3D"hl">-></span></span><span class=3D"n"><span class=3D"hl">cdr=
</span></span><span class=3D"p">,</span> <span class=3D"n">outbound</span><=
span class=3D"p">);</span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">526</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_init</span><span=
class=3D"p">(</span><span class=3D"n"><span class=3D"hl">ast_channel_cdr</=
span></span><span class=3D"p"><span class=3D"hl">(</span></span><span class=
=3D"n">outbound</span><span class=3D"p"><span class=3D"hl">)</span>,</span>=
<span class=3D"n">outbound</span><span class=3D"p">);</span></pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#f0f0f0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">527</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"p">}</span></pre></td>
<th bgcolor=3D"#f0f0f0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">527</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"p">}</span></pre></td>
</tr>
<tr>
<th bgcolor=3D"#f0f0f0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">528</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"p">}</span></pre></td>
<th bgcolor=3D"#f0f0f0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">528</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"p">}</span></pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">529</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"k">if</span> <span class=3D"p=
">(</span><span class=3D"n">outbound</span><span class=3D"o"><span class=3D=
"hl">-></span></span><span class=3D"n"><span class=3D"hl">cdr</span></sp=
an><span class=3D"p">)</span> <span class=3D"p">{</span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">529</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"k">if</span> <span class=3D"p=
"><span class=3D"hl">(</span></span><span class=3D"n"><span class=3D"hl">as=
t_channel_cdr</span></span><span class=3D"p">(</span><span class=3D"n">outb=
ound</span><span class=3D"p"><span class=3D"hl">)</span>)</span> <span clas=
s=3D"p">{</span></pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#f0f0f0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">530</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"kt">char</span> <span class=
=3D"n">tmp</span><span class=3D"p">[</span><span class=3D"mi">256</span><sp=
an class=3D"p">];</span></pre></td>
<th bgcolor=3D"#f0f0f0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">530</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"kt">char</span> <span class=
=3D"n">tmp</span><span class=3D"p">[</span><span class=3D"mi">256</span><sp=
an class=3D"p">];</span></pre></td>
</tr>
<tr>
<th bgcolor=3D"#f0f0f0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">531</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "></pre></td>
<th bgcolor=3D"#f0f0f0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">531</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor=3D"#f0f0f0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">532</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">snprintf</span><span clas=
s=3D"p">(</span><span class=3D"n">tmp</span><span class=3D"p">,</span> <spa=
n class=3D"k">sizeof</span><span class=3D"p">(</span><span class=3D"n">tmp<=
/span><span class=3D"p">),</span> <span class=3D"s">"%s/%s"</span=
><span class=3D"p">,</span> <span class=3D"s">"Local"</span><span=
class=3D"p">,</span> <span class=3D"n">tmpuser</span><span class=3D"o">-&g=
t;</span><span class=3D"n">dialarg</span><span class=3D"p">);</span></pre><=
/td>
<th bgcolor=3D"#f0f0f0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">532</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">snprintf</span><span clas=
s=3D"p">(</span><span class=3D"n">tmp</span><span class=3D"p">,</span> <spa=
n class=3D"k">sizeof</span><span class=3D"p">(</span><span class=3D"n">tmp<=
/span><span class=3D"p">),</span> <span class=3D"s">"%s/%s"</span=
><span class=3D"p">,</span> <span class=3D"s">"Local"</span><span=
class=3D"p">,</span> <span class=3D"n">tmpuser</span><span class=3D"o">-&g=
t;</span><span class=3D"n">dialarg</span><span class=3D"p">);</span></pre><=
/td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">533</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_setapp</span><spa=
n class=3D"p">(</span><span class=3D"n">outbound</span><span class=3D"o"><s=
pan class=3D"hl">-></span></span><span class=3D"n"><span class=3D"hl">cd=
r</span></span><span class=3D"p">,</span> <span class=3D"s">"FollowMe&=
quot;</span><span class=3D"p">,</span> <span class=3D"n">tmp</span><span cl=
ass=3D"p">);</span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">533</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_setapp</span><spa=
n class=3D"p">(</span><span class=3D"n"><span class=3D"hl">ast_channel_cdr<=
/span></span><span class=3D"p"><span class=3D"hl">(</span></span><span clas=
s=3D"n">outbound</span><span class=3D"p"><span class=3D"hl">)</span>,</span=
> <span class=3D"s">"FollowMe"</span><span class=3D"p">,</span> <=
span class=3D"n">tmp</span><span class=3D"p">);</span></pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#f0f0f0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">534</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_update</span><spa=
n class=3D"p">(</span><span class=3D"n">outbound</span><span class=3D"p">);=
</span></pre></td>
<th bgcolor=3D"#f0f0f0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">534</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_update</span><spa=
n class=3D"p">(</span><span class=3D"n">outbound</span><span class=3D"p">);=
</span></pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">535</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_start</span><span=
class=3D"p">(</span><span class=3D"n">outbound</span><span class=3D"o"><sp=
an class=3D"hl">-></span></span><span class=3D"n"><span class=3D"hl">cdr=
</span></span><span class=3D"p">);</span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">535</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_start</span><span=
class=3D"p">(</span><span class=3D"n"><span class=3D"hl">ast_channel_cdr</=
span></span><span class=3D"p"><span class=3D"hl">(</span></span><span class=
=3D"n">outbound</span><span class=3D"p"><span class=3D"hl">)</span>);</span=
></pre></td>
</tr>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">536</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_end</span><span c=
lass=3D"p">(</span><span class=3D"n">outbound</span><span class=3D"o"><span=
class=3D"hl">-></span></span><span class=3D"n"><span class=3D"hl">cdr</=
span></span><span class=3D"p">);</span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">536</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_end</span><span c=
lass=3D"p">(</span><span class=3D"n"><span class=3D"hl">ast_channel_cdr</sp=
an></span><span class=3D"p"><span class=3D"hl">(</span></span><span class=
=3D"n">outbound</span><span class=3D"p"><span class=3D"hl">)</span>);</span=
></pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#f0f0f0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">537</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"cm">/* If the cause wasn'=
;t handled properly */</span></pre></td>
<th bgcolor=3D"#f0f0f0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">537</font></th>
<td bgcolor=3D"#ffffff" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"cm">/* If the cause wasn'=
;t handled properly */</span></pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">538</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"k">if</span> <span class=3D"=
p">(</span><span class=3D"n">ast_cdr_disposition</span><span class=3D"p">(<=
/span><span class=3D"n">outbound</span><span class=3D"o"><span class=3D"hl"=
>-></span></span><span class=3D"n"><span class=3D"hl">cdr</span></span><=
span class=3D"p"><span class=3D"hl">,</span></span><span class=3D"hl"> </sp=
an><span class=3D"n"><span class=3D"hl">outbound</span></span><span class=
=3D"o"><span class=3D"hl">-></span></span><span class=3D"n">hangupcause<=
/span><span class=3D"p">))</span> <span class=3D"p">{</span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">538</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"k">if</span> <span class=3D"=
p">(</span><span class=3D"n">ast_cdr_disposition</span><span class=3D"p">(<=
/span><span class=3D"n"><span class=3D"hl">ast_channel_cdr</span></span><sp=
an class=3D"p"><span class=3D"hl">(</span></span><span class=3D"n">outbound=
</span><span class=3D"p"><span class=3D"hl">),</span></span><span class=3D"=
hl"> </span><span class=3D"n"><span class=3D"hl">ast_channel_</span>hangupc=
ause</span><span class=3D"p"><span class=3D"hl">(</span></span><span class=
=3D"n"><span class=3D"hl">outbound</span></span><span class=3D"p"><span cla=
ss=3D"hl">)</span>))</span> <span class=3D"p">{</span></pre></td>
</tr>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">539</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_failed</span><sp=
an class=3D"p">(</span><span class=3D"n">outbound</span><span class=3D"o"><=
span class=3D"hl">-></span></span><span class=3D"n"><span class=3D"hl">c=
dr</span></span><span class=3D"p">);</span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">539</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"n">ast_cdr_failed</span><sp=
an class=3D"p">(</span><span class=3D"n"><span class=3D"hl">ast_channel_cdr=
</span></span><span class=3D"p"><span class=3D"hl">(</span></span><span cla=
ss=3D"n">outbound</span><span class=3D"p"><span class=3D"hl">)</span>);</sp=
an></pre></td>
</tr>
</tbody>
</table>
<pre style=3D"margin-left: 2em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">As you come across passages like these, it may be worthwhile to add =
some comments to indicate that this should be looked at again once the opaq=
uification is completed. The reason is that there are a lot of calls to ast=
_channel_cdr() here, and it may be possible to call it once and set a local=
variable, then just use the local variable for the rest of the section.
Please don't make such actual changes now, but "todo"-style c=
omments are welcome.</pre>
</div>
<br />
<div>
<table width=3D"100%" border=3D"0" bgcolor=3D"white" style=3D"border: 1px s=
olid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan=3D"4" bgcolor=3D"#F0F0F0" style=3D"border-bottom: 1px solid =
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href=3D"https://reviewboard.asterisk.org/r/1753/diff/1/?file=3D24412=
#file24412line3649" style=3D"color: black; font-weight: bold; text-decorati=
on: underline;">/trunk/include/asterisk/channel.h</a>
<span style=3D"font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style=3D"background-color: #e4d9cb; padding: 4px 8px; text-align: c=
enter;">
<tr>
<td colspan=3D"4"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; ">void ast_channel_context_set(struct ast_channel *chan, const char *=
value);</pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#b1ebb0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2"></font></th>
<td bgcolor=3D"#c5ffc4" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "></pre></td>
<th bgcolor=3D"#b1ebb0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">3649</font></t=
h>
<td bgcolor=3D"#c5ffc4" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "><span class=3D"kt">char</span> <span class=3D"=
n">ast_channel_emulate_dtmf_digit</span><span class=3D"p">(</span><span cla=
ss=3D"k">const</span> <span class=3D"k">struct</span> <span class=3D"n">ast=
_channel</span> <span class=3D"o">*</span><span class=3D"n">chan</span><spa=
n class=3D"p">);</span></pre></td>
</tr>
<tr>
<th bgcolor=3D"#b1ebb0" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2"></font></th>
<td bgcolor=3D"#c5ffc4" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "></pre></td>
<th bgcolor=3D"#b1ebb0" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">3650</font></t=
h>
<td bgcolor=3D"#c5ffc4" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "><span class=3D"kt">void</span> <span class=3D"=
n">ast_channel_emulate_dtmf_digit_set</span><span class=3D"p">(</span><span=
class=3D"k">struct</span> <span class=3D"n">ast_channel</span> <span class=
=3D"o">*</span><span class=3D"n">chan</span><span class=3D"p">,</span> <spa=
n class=3D"kt">char</span> <span class=3D"n">value</span><span class=3D"p">=
);</span></pre></td>
</tr>
</tbody>
</table>
<pre style=3D"margin-left: 2em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">If at all possible, I'd rename these two functions. The accessor=
sounds like something you would call in order to emulate a DTMF digit. The=
setter just sounds like nonsense.</pre>
</div>
<br />
<p>- Mark</p>
<br />
<p>On February 18th, 2012, 1:45 p.m., Terry Wilson wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('https://reviewboard.asterisk.org/media/r=
b/images/review_request_box_top_bg.png'); background-position: left top; ba=
ckground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style=3D"color: grey;"><i>Updated Feb. 18, 2012, 1:45 p.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">This converts various int/long fields and most pointer field=
s. That leaves mostly structs, typedefs, a couple of int arrays and a coupl=
e of "problem fields". It might be a good idea for reviewers to a=
pply the patch and compile just in case I missed something somewhere.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">All unit tests pass. I got the same number of testsuite fail=
ures as a clean checkout of trunk.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/chan_mobile.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/addons/chan_ooh323.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/apps/app_alarmreceiver.c <span style=3D"color: grey">(355898)</=
span></li>
<li>/trunk/apps/app_authenticate.c <span style=3D"color: grey">(355898)</s=
pan></li>
<li>/trunk/apps/app_cdr.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/apps/app_chanisavail.c <span style=3D"color: grey">(355898)</sp=
an></li>
<li>/trunk/apps/app_channelredirect.c <span style=3D"color: grey">(355898)=
</span></li>
<li>/trunk/apps/app_chanspy.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/apps/app_confbridge.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/apps/app_dahdibarge.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/apps/app_dahdiras.c <span style=3D"color: grey">(355898)</span>=
</li>
<li>/trunk/apps/app_dial.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/apps/app_dictate.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/apps/app_directory.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/apps/app_disa.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/apps/app_dumpchan.c <span style=3D"color: grey">(355898)</span>=
</li>
<li>/trunk/apps/app_echo.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/apps/app_externalivr.c <span style=3D"color: grey">(355898)</sp=
an></li>
<li>/trunk/apps/app_fax.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/apps/app_festival.c <span style=3D"color: grey">(355898)</span>=
</li>
<li>/trunk/apps/app_flash.c <span style=3D"color: grey">(355898)</span></l=
i>
<li>/trunk/apps/app_followme.c <span style=3D"color: grey">(355898)</span>=
</li>
<li>/trunk/apps/app_forkcdr.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/apps/app_ices.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/apps/app_ivrdemo.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/apps/app_macro.c <span style=3D"color: grey">(355898)</span></l=
i>
<li>/trunk/apps/app_meetme.c <span style=3D"color: grey">(355898)</span></=
li>
<li>/trunk/apps/app_milliwatt.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/apps/app_minivm.c <span style=3D"color: grey">(355898)</span></=
li>
<li>/trunk/apps/app_osplookup.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/apps/app_parkandannounce.c <span style=3D"color: grey">(355898)=
</span></li>
<li>/trunk/apps/app_playback.c <span style=3D"color: grey">(355898)</span>=
</li>
<li>/trunk/apps/app_playtones.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/apps/app_privacy.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/apps/app_queue.c <span style=3D"color: grey">(355898)</span></l=
i>
<li>/trunk/apps/app_read.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/apps/app_readexten.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/apps/app_record.c <span style=3D"color: grey">(355898)</span></=
li>
<li>/trunk/apps/app_rpt.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/apps/app_sayunixtime.c <span style=3D"color: grey">(355898)</sp=
an></li>
<li>/trunk/apps/app_sendtext.c <span style=3D"color: grey">(355898)</span>=
</li>
<li>/trunk/apps/app_sms.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/apps/app_softhangup.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/apps/app_speech_utils.c <span style=3D"color: grey">(355898)</s=
pan></li>
<li>/trunk/apps/app_stack.c <span style=3D"color: grey">(355898)</span></l=
i>
<li>/trunk/apps/app_talkdetect.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/apps/app_test.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/apps/app_transfer.c <span style=3D"color: grey">(355898)</span>=
</li>
<li>/trunk/apps/app_verbose.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/apps/app_voicemail.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/apps/app_waitforsilence.c <span style=3D"color: grey">(355898)<=
/span></li>
<li>/trunk/apps/app_while.c <span style=3D"color: grey">(355898)</span></l=
i>
<li>/trunk/apps/app_zapateller.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/bridges/bridge_builtin_features.c <span style=3D"color: grey">(=
355898)</span></li>
<li>/trunk/bridges/bridge_multiplexed.c <span style=3D"color: grey">(35589=
8)</span></li>
<li>/trunk/bridges/bridge_simple.c <span style=3D"color: grey">(355898)</s=
pan></li>
<li>/trunk/cdr/cdr_custom.c <span style=3D"color: grey">(355898)</span></l=
i>
<li>/trunk/cdr/cdr_manager.c <span style=3D"color: grey">(355898)</span></=
li>
<li>/trunk/cdr/cdr_sqlite3_custom.c <span style=3D"color: grey">(355898)</=
span></li>
<li>/trunk/cdr/cdr_syslog.c <span style=3D"color: grey">(355898)</span></l=
i>
<li>/trunk/channels/chan_agent.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/channels/chan_alsa.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/channels/chan_bridge.c <span style=3D"color: grey">(355898)</sp=
an></li>
<li>/trunk/channels/chan_console.c <span style=3D"color: grey">(355898)</s=
pan></li>
<li>/trunk/channels/chan_dahdi.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/channels/chan_gtalk.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/channels/chan_h323.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/channels/chan_iax2.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/channels/chan_jingle.c <span style=3D"color: grey">(355898)</sp=
an></li>
<li>/trunk/channels/chan_local.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/channels/chan_mgcp.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/channels/chan_misdn.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/channels/chan_multicast_rtp.c <span style=3D"color: grey">(3558=
98)</span></li>
<li>/trunk/channels/chan_nbs.c <span style=3D"color: grey">(355898)</span>=
</li>
<li>/trunk/channels/chan_oss.c <span style=3D"color: grey">(355898)</span>=
</li>
<li>/trunk/channels/chan_phone.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/channels/chan_sip.c <span style=3D"color: grey">(355898)</span>=
</li>
<li>/trunk/channels/chan_skinny.c <span style=3D"color: grey">(355898)</sp=
an></li>
<li>/trunk/channels/chan_unistim.c <span style=3D"color: grey">(355898)</s=
pan></li>
<li>/trunk/channels/chan_usbradio.c <span style=3D"color: grey">(355898)</=
span></li>
<li>/trunk/channels/chan_vpb.cc <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/channels/sig_analog.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/channels/sig_pri.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/channels/sig_ss7.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/channels/sip/dialplan_functions.c <span style=3D"color: grey">(=
355898)</span></li>
<li>/trunk/funcs/func_callerid.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/funcs/func_cdr.c <span style=3D"color: grey">(355898)</span></l=
i>
<li>/trunk/funcs/func_channel.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/funcs/func_jitterbuffer.c <span style=3D"color: grey">(355898)<=
/span></li>
<li>/trunk/funcs/func_timeout.c <span style=3D"color: grey">(355898)</span=
></li>
<li>/trunk/include/asterisk/channel.h <span style=3D"color: grey">(355898)=
</span></li>
<li>/trunk/include/asterisk/sched.h <span style=3D"color: grey">(355898)</=
span></li>
<li>/trunk/main/abstract_jb.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/main/app.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/audiohook.c <span style=3D"color: grey">(355898)</span></l=
i>
<li>/trunk/main/bridging.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/ccss.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/cdr.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/cel.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/channel.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/channel_internal_api.c <span style=3D"color: grey">(355898=
)</span></li>
<li>/trunk/main/cli.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/devicestate.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/main/dial.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/features.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/file.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/framehook.c <span style=3D"color: grey">(355898)</span></l=
i>
<li>/trunk/main/image.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/manager.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/message.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/pbx.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/main/rtp_engine.c <span style=3D"color: grey">(355898)</span></=
li>
<li>/trunk/main/udptl.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/pbx/pbx_lua.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/pbx/pbx_realtime.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/res/res_adsi.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/res/res_agi.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/res/res_calendar.c <span style=3D"color: grey">(355898)</span><=
/li>
<li>/trunk/res/res_fax.c <span style=3D"color: grey">(355898)</span></li>
<li>/trunk/res/res_monitor.c <span style=3D"color: grey">(355898)</span></=
li>
<li>/trunk/res/res_musiconhold.c <span style=3D"color: grey">(355898)</spa=
n></li>
<li>/trunk/res/res_rtp_asterisk.c <span style=3D"color: grey">(355898)</sp=
an></li>
<li>/trunk/res/snmp/agent.c <span style=3D"color: grey">(355898)</span></l=
i>
</ul>
<p><a href=3D"https://reviewboard.asterisk.org/r/1753/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4722371582759062148==--
More information about the asterisk-dev
mailing list