No subject
Fri Sep 2 03:59:05 CDT 2011
"It's true that res_fax.so does not have 'reload' support. Per kpfleming an=
d tlesher, if the module has configuration options, it is expected behaviou=
r that we would support reloads, so to close this issue we need to add relo=
ad support.
For now, the work around is to unload and load the module to cause changes =
to happen."
It sounds as though this was discussed previously and determined to be a bu=
g, rather than a feature request.
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1713/#review5397
-----------------------------------------------------------
On Feb. 3, 2012, 11:26 a.m., Mark Michelson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1713/
> -----------------------------------------------------------
> =
> (Updated Feb. 3, 2012, 11:26 a.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> Since res_fax has configurable options, it needs reload support. This pat=
ch adds reload support to res_fax.
> =
> =
> This addresses bug ASTERISK-16712.
> https://issues.asterisk.org/jira/browse/ASTERISK-16712
> =
> =
> Diffs
> -----
> =
> /branches/1.8/res/res_fax.c 353917 =
> =
> Diff: https://reviewboard.asterisk.org/r/1713/diff
> =
> =
> Testing
> -------
> =
> Confirmed that "module reload res_fax.so" is operational and properly loa=
ds new configuration options.
> =
> =
> Thanks,
> =
> Mark
> =
>
--===============0816957480692376395==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"https://reviewboard.asterisk.org/r/1713/">https://reviewbo=
ard.asterisk.org/r/1713/</a>
</td>
</tr>
</table>
<br />
<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; padd=
ing-left: 10px;">
<p style=3D"margin-top: 0;">On February 3rd, 2012, 11:41 a.m., <b>Paul Bel=
anger</b> wrote:</p>
<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should=
9;t this be for trunk since this is a new feature?</pre>
</blockquote>
</blockquote>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spac=
e: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From the li=
nked issue, Leif left this comment:
"It's true that res_fax.so does not have 'reload' support.=
Per kpfleming and tlesher, if the module has configuration options, it is =
expected behaviour that we would support reloads, so to close this issue we=
need to add reload support.
For now, the work around is to unload and load the module to cause changes =
to happen."
It sounds as though this was discussed previously and determined to be a bu=
g, rather than a feature request.</pre>
<br />
<p>- Mark</p>
<br />
<p>On February 3rd, 2012, 11:26 a.m., Mark Michelson wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('https://reviewboard.asterisk.org/media/r=
b/images/review_request_box_top_bg.png'); background-position: left top; ba=
ckground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style=3D"color: grey;"><i>Updated Feb. 3, 2012, 11:26 a.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Since res_fax has configurable options, it needs reload supp=
ort. This patch adds reload support to res_fax.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Confirmed that "module reload res_fax.so" is opera=
tional and properly loads new configuration options.</pre>
</td>
</tr>
</table>
<div style=3D"margin-top: 1.5em;">
<b style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href=3D"https://issues.asterisk.org/jira/browse/ASTERISK-16712">ASTERIS=
K-16712</a>
</div>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/res/res_fax.c <span style=3D"color: grey">(353917)</span=
></li>
</ul>
<p><a href=3D"https://reviewboard.asterisk.org/r/1713/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0816957480692376395==--
More information about the asterisk-dev
mailing list