No subject
Fri Sep 2 03:59:05 CDT 2011
<kpfleming> it's already unique enough, and free
- jrose
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1643/#review5067
-----------------------------------------------------------
On Dec. 22, 2011, 12:03 p.m., telecos82 wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1643/
> -----------------------------------------------------------
> =
> (Updated Dec. 22, 2011, 12:03 p.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> Currently, if there are several MixMonitor started on a channel, there is=
no way to specify which MixMonitor to stop with StopMixMonitor. With this =
patch we will allow this. One limitation of current implementation was that=
mixmonitor datastore was not identified with a uid so there was no way to =
identify a concrete MixMonitor. Furthermore, when retrieving audiohook to d=
ettach from channel, there was no control on which audiohook to dettach, it=
always got first audiohook found of type mixmonitor_spy_type. With this pa=
tch we are identifying MixMonitor datastore by the filename asociated to it=
, and dettaching the concrete audiohook contained on datastore. Furthermore=
a new CLI command "mixmonitor list <channel_name>" to help querying active=
mixmonitors on a channel.
> =
> =
> This addresses bug ASTERISK-19096.
> https://issues.asterisk.org/jira/browse/ASTERISK-19096
> =
> =
> Diffs
> -----
> =
> http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c 348737 =
> =
> Diff: https://reviewboard.asterisk.org/r/1643/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> telecos82
> =
>
--===============8018828338553656680==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"https://reviewboard.asterisk.org/r/1643/">https://reviewbo=
ard.asterisk.org/r/1643/</a>
</td>
</tr>
</table>
<br />
<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; padd=
ing-left: 10px;">
<p style=3D"margin-top: 0;">On December 22nd, 2011, 3:07 p.m., <b>jrose</b=
> wrote:</p>
<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alright, =
this looks good.</pre>
</blockquote>
<p>On December 22nd, 2011, 3:08 p.m., <b>jrose</b> wrote:</p>
<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">EDIT: Ac=
tually, revoke that. Missed kpfleming's recent post.</pre>
</blockquote>
<p>On December 22nd, 2011, 3:15 p.m., <b>jrose</b> wrote:</p>
<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, so wh=
at kpfleming is suggesting is basically this...
Create the search term based on something supplied to mixmonitor via an arg=
ument. Like...
MixMonitor(filename.extension,i(name_of_channel_variable))
When mixmonitor is created and this option is present, this channel variabl=
e will be populated with some uniquely identifying string (at least uniquel=
y identifying for the channel) which you'll need to create with some he=
uristic... possibly involving the system time that the variable is created =
or something similar.
Then from there you'd just use that as your identifier for stopmixmonit=
or.</pre>
</blockquote>
</blockquote>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spac=
e: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From IRC:
<kpfleming> jrose_atDigium: the most easily usable data for that MixM=
onitor token would be the address of the datastore, formatted in hex
<kpfleming> it's already unique enough, and free</pre>
<br />
<p>- jrose</p>
<br />
<p>On December 22nd, 2011, 12:03 p.m., telecos82 wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('https://reviewboard.asterisk.org/media/r=
b/images/review_request_box_top_bg.png'); background-position: left top; ba=
ckground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By telecos82.</div>
<p style=3D"color: grey;"><i>Updated Dec. 22, 2011, 12:03 p.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Currently, if there are several MixMonitor started on a chan=
nel, there is no way to specify which MixMonitor to stop with StopMixMonito=
r. With this patch we will allow this. One limitation of current implementa=
tion was that mixmonitor datastore was not identified with a uid so there w=
as no way to identify a concrete MixMonitor. Furthermore, when retrieving a=
udiohook to dettach from channel, there was no control on which audiohook t=
o dettach, it always got first audiohook found of type mixmonitor_spy_type.=
With this patch we are identifying MixMonitor datastore by the filename as=
ociated to it, and dettaching the concrete audiohook contained on datastore=
. Furthermore a new CLI command "mixmonitor list <channel_name>&=
quot; to help querying active mixmonitors on a channel.</pre>
</td>
</tr>
</table>
<div style=3D"margin-top: 1.5em;">
<b style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href=3D"https://issues.asterisk.org/jira/browse/ASTERISK-19096">ASTERIS=
K-19096</a>
</div>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c <span=
style=3D"color: grey">(348737)</span></li>
</ul>
<p><a href=3D"https://reviewboard.asterisk.org/r/1643/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8018828338553656680==--
More information about the asterisk-dev
mailing list