No subject


Fri Sep 2 03:59:05 CDT 2011


using the old-style VERBOSE_PREFIX_*.

Shouldn't the magic number be calculated after the re-setting of level =
that happens in the level =3D=3D -1 if.</pre>
 </blockquote>





</blockquote>
<pre style=3D"margin-left: 1em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">Fixed.

It&#39;s just bounds checking.  If we&#39;re passed a negative level (see t=
he ast_verbose() macro), then we want to scan the string to detect verbose =
level.  So yes, the ordering was intentional.</pre>
<br />




<p>- Tilghman</p>


<br />
<p>On November 27th, 2011, 8:33 p.m., Tilghman Lesher wrote:</p>






<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('https://reviewboard.asterisk.org/media/r=
b/images/review_request_box_top_bg.png'); background-position: left top; ba=
ckground-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Tilghman Lesher.</div>


<p style=3D"color: grey;"><i>Updated Nov. 27, 2011, 8:33 p.m.</i></p>




<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">One problem that many admins have today is that to have maxi=
mum verbosity going to the logs, for later debugging of trouble calls, the =
console becomes virtually unusable, because the verbosity level is global. =
 This patch attempts to solve that problem, allowing each verbose recipient=
 to have its own filter as to what it wants to receive.</pre>
  </td>
 </tr>
</table>


<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Verified logging with files, consoles with different verbosi=
ty levels, etc.</pre>
  </td>
 </tr>
</table>




<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>/trunk/addons/chan_ooh323.c <span style=3D"color: grey">(346290)</span=
></li>

 <li>/trunk/addons/res_config_mysql.c <span style=3D"color: grey">(346290)<=
/span></li>

 <li>/trunk/apps/app_rpt.c <span style=3D"color: grey">(346290)</span></li>

 <li>/trunk/apps/app_verbose.c <span style=3D"color: grey">(346290)</span><=
/li>

 <li>/trunk/apps/app_voicemail.c <span style=3D"color: grey">(346290)</span=
></li>

 <li>/trunk/channels/chan_sip.c <span style=3D"color: grey">(346290)</span>=
</li>

 <li>/trunk/channels/chan_skinny.c <span style=3D"color: grey">(346290)</sp=
an></li>

 <li>/trunk/channels/chan_usbradio.c <span style=3D"color: grey">(346290)</=
span></li>

 <li>/trunk/codecs/codec_dahdi.c <span style=3D"color: grey">(346290)</span=
></li>

 <li>/trunk/configs/logger.conf.sample <span style=3D"color: grey">(346290)=
</span></li>

 <li>/trunk/include/asterisk/logger.h <span style=3D"color: grey">(346290)<=
/span></li>

 <li>/trunk/main/asterisk.c <span style=3D"color: grey">(346290)</span></li>

 <li>/trunk/main/bridging.c <span style=3D"color: grey">(346290)</span></li>

 <li>/trunk/main/cli.c <span style=3D"color: grey">(346290)</span></li>

 <li>/trunk/main/dial.c <span style=3D"color: grey">(346290)</span></li>

 <li>/trunk/main/logger.c <span style=3D"color: grey">(346290)</span></li>

 <li>/trunk/main/say.c <span style=3D"color: grey">(346290)</span></li>

 <li>/trunk/res/res_clialiases.c <span style=3D"color: grey">(346290)</span=
></li>

 <li>/trunk/res/res_fax.c <span style=3D"color: grey">(346290)</span></li>

 <li>/trunk/res/res_jabber.c <span style=3D"color: grey">(346290)</span></l=
i>

 <li>/trunk/res/res_musiconhold.c <span style=3D"color: grey">(346290)</spa=
n></li>

</ul>

<p><a href=3D"https://reviewboard.asterisk.org/r/1599/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============7365772916121709521==--



More information about the asterisk-dev mailing list