[asterisk-dev] [Code Review] Run a macro on picked up channel when bridging

irroot reviewboard at asterisk.org
Thu Sep 29 13:39:54 CDT 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 29, 2011, 1:39 p.m.)

Review request for Asterisk Developers.


Complete redo of the patch im using in all systems.

when a channel is picked up put a datastore on the channel that will be checked in ast_channel_bridge
if the datastore exists and a channel variable PICKUP_BRIDGE_MACRO is set this macro is run on the 
picked up channel and the datastore removed.

Included is doc's in CHANGES app_directedpickup and features.conf

Summary (updated)

as a companion to 0018825 to aid with the move from call-limits to channel group variables. the problem with pickup and queue is that they manage channels outside the dialplan and need "helpers" to deal with channel groups.

in the case of pickup when a call is placed to a extension with say a "<EXTEN>@called" channel group when it is picked up this needs to be cleared to allow further calls when call waiting is disabled.

exten => s,n,GotoIf($[$[${ GROUP_COUNT(${ARG1}@called)} >= 1] | $[${GROUP_COUNT(${ARG1}@caller)} >= 1] | $[${GROUP_COUNT(${ARG1}@pickup)} >= 1] | $[${GROUP_COUNT(${ARG1}@qagent)} >= 1]]?s-BUSY,1)

caller is set when a call is placed.
called is set when a call is received
pickup is set when before calling pickup in the dialplan
qagent is set with patch to queue

Hope this is found to be useful and finds a home in trunk. 

not sure what time to put in the "wait for bridge" perhaps there is a better method ?? 

This addresses bug 18830.

Diffs (updated)

  /trunk/main/global_datastores.c 338435 
  /trunk/main/features.c 338435 
  /trunk/main/channel.c 338435 
  /trunk/configs/features.conf.sample 338435 
  /trunk/include/asterisk/global_datastores.h 338435 
  /trunk/apps/app_directed_pickup.c 338435 
  /trunk/CHANGES 338435 

Diff: https://reviewboard.asterisk.org/r/1118/diff




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110929/622ac4d8/attachment.htm>

More information about the asterisk-dev mailing list