[asterisk-dev] [Code Review]: Adjust formats of chan_local when channel we proxying changes

[irroot]

> On July 27, 2011, 9:56 a.m., David Vossel wrote:
> > /trunk/channels/chan_local.c, lines 613-617
> > <https://reviewboard.asterisk.org/r/1137/diff/5/?file=17622#file17622line613>
> >
> >     ast is locked here, ast and the tech_pvt must be unlocked before grabbing p->chan's lock.

ast cannot be unlocked here as we need it locked to prevent problems with ast_bridged_channel it comes into the function
locked from ast_write()

we have 
ast is p->owner the lead local chan
p->chan is the twin local
bridge is the real channel

what we doing here is copying the nativeformats from the real channel to the local channel's peer and fixing up the formats.

the latest patch  will unlock the pvt as mentioned above and put some deadlock avoidance in place on p->chan.

Greg


- irroot


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1137/#review3938
-----------------------------------------------------------


On Sept. 27, 2011, 5:04 a.m., irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1137/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2011, 5:04 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a most annoying pain and tripped me up no end testing the T38 gateway patch for res_fax.
> 
> Scenario :-
> 
> i have a Linksys 2102 on a fax machine that uses G.729 and switches to ALAW on CNG and then negotiates T.38
> this is awesome as i can now Chat/Fax from same terminal using most effective bandwidth [these are to be deployed
> on sugar cane farms surrounding the kruger park here in south africa over wi-fi]
> 
> for testing purposes im using a local channel into T.30 fax app in res_fax.
> 
> Problem :-
> 
> when the device reinvites ALAW then T.38 it leaves the nativeformat on chan_local as G.729 this will not work
> as it is transcoding the FAX from G.729 to SLIN this will not work and took me a while to spot the problem.
> 
> Soloution :-
> 
> Check the format on the proxy and adjust it if it changes this should be what Local does been a proxy of the channel
> it should follow changes ...
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_local.c 337898 
> 
> Diff: https://reviewboard.asterisk.org/r/1137/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110927/d57bac1c/attachment.htm>