[asterisk-dev] [Code Review] Clean up logger.conf parsing

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1457/#review4437
-----------------------------------------------------------



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/1457/#comment8578>

    According to the reset-defaults-between-UNCHANGED-and-FILEMISSING logic, these defaults shouldn't be set here, but there.



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/1457/#comment8577>

    Shouldn't these two be after the "if no config file...set default options"? And the add the other stuff from above.



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/1457/#comment8576>

    s/"unknown"/ast_config_AST_SYSTEM_NAME/
    
    and
    
    s/fprintf/ast_log(LOG_ERROR)/
    
    (same behaviour as the asterisk.conf)


- wdoekes


On Sept. 23, 2011, 2:30 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1457/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 2:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch helps clean up logger.conf for parsing of the [general] section.
> 
> 
> Diffs
> -----
> 
>   trunk/main/logger.c 337894 
> 
> Diff: https://reviewboard.asterisk.org/r/1457/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110924/f8f8e78e/attachment-0001.htm>