[asterisk-dev] [Code Review] Clean up asterisk.conf parsing
Tilghman Lesher
reviewboard at asterisk.org
Fri Sep 23 23:52:20 CDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1462/#review4432
-----------------------------------------------------------
trunk/main/asterisk.c
<https://reviewboard.asterisk.org/r/1462/#comment8565>
Since we don't ever pass CONFIG_FLAG_FILEUNCHANGED, this condition is impossible.
trunk/main/asterisk.c
<https://reviewboard.asterisk.org/r/1462/#comment8566>
Looks like you've completely removed the WARNING message. I think it should be restored here.
- Tilghman
On Sept. 23, 2011, 9:39 p.m., Paul Belanger wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1462/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2011, 9:39 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> Last one for the day :D This is pretty minor clean up of asterisk.conf
>
>
> Diffs
> -----
>
> trunk/main/asterisk.c 337894
>
> Diff: https://reviewboard.asterisk.org/r/1462/diff
>
>
> Testing
> -------
>
> local development box
>
>
> Thanks,
>
> Paul
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110924/0cc6e483/attachment-0001.htm>
More information about the asterisk-dev
mailing list