[asterisk-dev] [Code Review] Include test output in results XML file

Paul Belanger reviewboard at asterisk.org
Fri Sep 23 16:06:16 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1459/#review4430
-----------------------------------------------------------

Ship it!


Nice work


/asterisk/trunk/runtests.py
<https://reviewboard.asterisk.org/r/1459/#comment8563>

    


- Paul


On Sept. 23, 2011, 3:55 p.m., Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1459/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 3:55 p.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and mjordan.
> 
> 
> Summary
> -------
> 
> This patch adds test output as retrieve on stdout to the test results XML file. The output is sanitized to remove characters that are illegal in XML and escape special XML characters.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/runtests.py 2443 
> 
> Diff: https://reviewboard.asterisk.org/r/1459/diff
> 
> 
> Testing
> -------
> 
> Tested with bamboo by generating an XML file on the fly with illegal characters in it and running it through the new code.
> 
> 
> Thanks,
> 
> Matthew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110923/7949fde3/attachment.htm>


More information about the asterisk-dev mailing list