[asterisk-dev] [Code Review] New DUNDi cli commands to list cache entries

[Leif Madsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1438/
-----------------------------------------------------------

(Updated Sept. 22, 2011, 8:01 a.m.)


Review request for Asterisk Developers, Russell Bryant and Paul Belanger.


Changes
-------

Per developer on issue:


* Added braces { } to if (in case of all cli commands as well)
* Changed "while (...)"
* The "continue" structure proposed will not work with the current "while" implementation because "db_entry = db_entry->next" would not be called. This would result in an endless loop. I think, "continue" would not improve readability either.
* Refactoring the string manipulation
* Fixed a possible bug


Summary
-------

This patch adds the following cli commands for DUNDi:

dundi show cache: List DUNDi cache entries
dundi show hints: List DUNDi 'DONTASK' hints in the cache


(Developer is Peter Racz from JIRA)


This addresses bug ASTERISK-18390.
    https://issues.asterisk.org/jira/browse/ASTERISK-18390


Diffs (updated)
-----

  branches/10/pbx/pbx_dundi.c 337177 

Diff: https://reviewboard.asterisk.org/r/1438/diff


Testing
-------

I've tested this on my Asterisk 10 box, and the commands work as I would expect.


Thanks,

Leif

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110922/183c281a/attachment.htm>