[asterisk-dev] [Code Review] Generate security events in chan_sip using new Security Events Framework

[elguero]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1362/
-----------------------------------------------------------

(Updated Sept. 21, 2011, 8:25 a.m.)


Review request for Asterisk Developers.


Changes
-------

- Addresses comments in regards to logger.conf.sample


Summary
-------

Security Events Framework was added in 1.8 and support was added for AMI to generate events at that time.

This patch attempts to add support in chan_sip to generate security events.  Hopefully we can get this into Asterisk 10.

I am looking forward to hearing feedback on where this patch can be improved especially from those who have an intimate knowledge of chan_sip.

Thanks


This addresses bug ASTERISK-18264.
    https://issues.asterisk.org/jira/browse/ASTERISK-18264


Diffs (updated)
-----

  /branches/10/CHANGES 337324 
  /branches/10/channels/chan_sip.c 337324 
  /branches/10/channels/sip/include/sip.h 337324 
  /branches/10/configs/logger.conf.sample 337324 
  /branches/10/include/asterisk/event_defs.h 337324 
  /branches/10/include/asterisk/security_events_defs.h 337324 
  /branches/10/main/event.c 337324 
  /branches/10/main/security_events.c 337324 

Diff: https://reviewboard.asterisk.org/r/1362/diff


Testing
-------

Local dev machine and a softphone.  Generated events by using the wrong username, wrong password, wrong auth name, successful authentication.


Thanks,

elguero

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110921/a9687399/attachment.htm>