[asterisk-dev] [Code Review]: Plenty of review done - Set channel variables with setvar= when manager user originates calls

[Olle E Johansson]

> On Sept. 20, 2011, 12:56 p.m., Tilghman Lesher wrote:
> > I'm having a fundamental issue with this change.  When we're talking about something like the "channelvars" parameter, which emits extra details in each response, those details can be ignored, and it won't have an effect.  But the issue here is that you're modifying the parameter list, and you're not providing a method to override those presets.  Beyond this, even the name seems wrong.  Whereas channel variables in sip.conf are populated every time the channel is instantiated, this new parameter only applies to a very limited set of commands (one!) in AMI.
> 
> Olle E Johansson wrote:
>     I don't understand. If you use setvar= on a manager account you can override per call with the variable setting in the originate command.
> 
> Tilghman Lesher wrote:
>     If you don't want to set any variables?  There is no "unset" when it comes to variables (nor should there be, as it pertains to channel variables).

That can be a feature too. As a manager, I want to set variables that is later used for filtering. This is primarily for multi hosting and situations where you have windows desktop clients that originate calls - as an admin, you want to force variables to be set.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1412/#review4380
-----------------------------------------------------------


On Sept. 15, 2011, 10:11 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1412/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2011, 10:11 a.m.)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> When the manager originates calls, there's no way to add channel variables. THis patch adds a setvar= option in manager.conf for a specific account, much like in sip.conf
> 
> This is different form variables in the originate in that these are set on every call, regardless of settings in the manager client software. Good for usage in combination with the manager event filters.
> 
> 
> This addresses bug 18143.
>     https://issues.asterisk.org/jira/browse/18143
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 336090 
>   /trunk/Makefile 336090 
>   /trunk/configs/manager.conf.sample 336090 
>   /trunk/include/asterisk/config.h 336090 
>   /trunk/main/config.c 336090 
>   /trunk/main/manager.c 336090 
> 
> Diff: https://reviewboard.asterisk.org/r/1412/diff
> 
> 
> Testing
> -------
> 
> In-house testing while developing. Channel variables added (proved by dumpchan() )
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110920/ea29106b/attachment.htm>