[asterisk-dev] [Code Review] extenpatternmatchnew breaks ability for caller to exit queue

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1367/#review4393
-----------------------------------------------------------

Ship it!


Tested BackgroundDetect and VoiceMail with the patch (both of which use the ast_canmatch_extension dialplan application in addition to app_queue), and execution matched the previous behavior without the patch.  What's more, this appears to make the execution of ast_canmatch_extension match the documented behavior.

- mjordan


On Aug. 17, 2011, 3:48 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1367/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2011, 3:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When checking an extension for E_CANMATCH using the new extension matching algorithm, an exact match is not returned as a possible match resulting in the queue failing to allow a caller to exit on DTMF.  This removes the requirement that an extension be longer than acquired digits for an E_CANMATCH operation to succeed.
> 
> 
> This addresses bug ASTERISK-18044.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18044
> 
> 
> Diffs
> -----
> 
>   trunk/main/pbx.c 332337 
>   trunk/tests/test_pbx.c 332337 
> 
> Diff: https://reviewboard.asterisk.org/r/1367/diff
> 
> 
> Testing
> -------
> 
> Tested with the new extension matcher vs the old extension match with extensions of length 1 and 2 to verify corrected behavior in the presence of other extensions and alone.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110920/51cedd8b/attachment.htm>