[asterisk-dev] [Code Review]: Change default strictrtp to "yes" - enabled - in rtp.conf.sample and res_rtp_asterisk.c

Olle E Johansson reviewboard at asterisk.org
Tue Sep 20 10:26:00 CDT 2011



> On Sept. 20, 2011, 10:24 a.m., Leif Madsen wrote:
> > /branches/10/configs/rtp.conf.sample, line 21
> > <https://reviewboard.asterisk.org/r/1448/diff/1/?file=20815#file20815line21>
> >
> >     Red blob

But outside of my changes... And in the config files I don't pay much attention to them.


> On Sept. 20, 2011, 10:24 a.m., Leif Madsen wrote:
> > /branches/10/configs/rtp.conf.sample, line 26
> > <https://reviewboard.asterisk.org/r/1448/diff/1/?file=20815#file20815line26>
> >
> >     Hey bonus! Now our documentation reflects what is the default :)

;-) 
Thanks for the review.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1448/#review4388
-----------------------------------------------------------


On Sept. 20, 2011, 10:16 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1448/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2011, 10:16 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> It's time to change strictrtp default behavior to "yes". 
> 
> 
> This addresses bug ASTERISK-18587.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18587
> 
> 
> Diffs
> -----
> 
>   /branches/10/configs/rtp.conf.sample 336933 
>   /branches/10/res/res_rtp_asterisk.c 336933 
> 
> Diff: https://reviewboard.asterisk.org/r/1448/diff
> 
> 
> Testing
> -------
> 
> Looked at the code. Compiled.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110920/e1f3ae7a/attachment-0001.htm>


More information about the asterisk-dev mailing list