[asterisk-dev] [Code Review]: Set Write format if it does not match native format or current write format.

[irroot]

> On Sept. 19, 2011, 1:18 p.m., Tilghman Lesher wrote:
> > /branches/1.8/main/channel.c, lines 4894-4897
> > <https://reviewboard.asterisk.org/r/1442/diff/1/?file=20686#file20686line4894>
> >
> >     You still need to log a WARNING here.  It is not fair game to allow channel drivers to skip the step of setting the new codec explicitly.

[Sep 20 09:57:24] WARNING[8403]: channel.c:4900 ast_write: Codec mismatch on channel Console/dsp setting write format to alaw from slin nativeformats 0x40 (slin)

The above is when i tried to call a DAHDI channel from  Console/dsp via AGI this is a FXO port connected to a cell router [Psitek Fusion]

   -- AGI Script Executing Application: (Dial) Options: (DAHDI/3/wwwwXXXXX|60|FgrL(32853000))
   -- Setting call duration limit to 32853.000 seconds.
   -- Called DAHDI/3/wwwwXXXXXX


- irroot


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1442/#review4370
-----------------------------------------------------------


On Sept. 20, 2011, 2:56 a.m., irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1442/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2011, 2:56 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Its possible to loose audio on ast_write when the channel is not transcoded correctly.
> 
> in the case of DAHDI the channel is hungup.
> 
> a simple check and fix solves this problem.
> 
> Many support issues are open over this issue.
> 
> 
> This addresses bugs ASTERISK-14384, ASTERISK-17502, ASTERISK-17541, ASTERISK-18063, ASTERISK-18325, and ASTERISK-18422.
>     https://issues.asterisk.org/jira/browse/ASTERISK-14384
>     https://issues.asterisk.org/jira/browse/ASTERISK-17502
>     https://issues.asterisk.org/jira/browse/ASTERISK-17541
>     https://issues.asterisk.org/jira/browse/ASTERISK-18063
>     https://issues.asterisk.org/jira/browse/ASTERISK-18325
>     https://issues.asterisk.org/jira/browse/ASTERISK-18422
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/channel.c 336930 
> 
> Diff: https://reviewboard.asterisk.org/r/1442/diff
> 
> 
> Testing
> -------
> 
> This patch has been in use by me in production for a long period and has resolved these issues and works as expected.
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110920/3f66682a/attachment.htm>