[asterisk-dev] [Code Review] Manager originate: Don't fall back to "s" when given extension does not exist

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1445/#review4368
-----------------------------------------------------------

Ship it!


Code looks good, but due to behavior change, I think we should hold off with this change until Asterisk 10.

- Tilghman


On Sept. 19, 2011, 1:07 p.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1445/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 1:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, if a manager originate tries to access an extension that does not exist, pbx.c ast_pbx_start makes the call fall over to "s at default" which should *not* be the case.
> 
> We agreed on IRC to fix pbx_start later, but this patch (aimed at 1.8) fixes the manager command so that (in the manner of the SIP channel) we check for the extension before trying the call. This will affect current behaviour and should be documented properly. It may affect applications that rely on this - users may have built dialplans that use "s" this way instead of fixing a fallback within their application. We might want to have an option in manager.conf to preserve old behaviour for this reason. 
> 
> Separately, we should check other originate (CLI, app) as well, but let's separate the patches. 
> 
> Background: extension "s" should ONLY be used when NO extension is given. It's not a wildcard and not a fallback when things go wrong. 
> 
> Side note: The bug exists in 1.4 too, so in all 1.6.x releases.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/manager.c 336574 
> 
> Diff: https://reviewboard.asterisk.org/r/1445/diff
> 
> 
> Testing
> -------
> 
> Feels like the code compiles on OS/X. This review is more about if we want to fix this in 1.8 and how. After that, I'll test the code.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110919/f2a8db33/attachment.htm>