[asterisk-dev] [Code Review] Add manager event for early media
Olle E Johansson
reviewboard at asterisk.org
Mon Sep 19 06:43:04 CDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1187/
-----------------------------------------------------------
(Updated Sept. 19, 2011, 6:43 a.m.)
Review request for Asterisk Developers and Russell Bryant.
Changes
-------
Updated according to Matthew's review.
Summary
-------
Add a manager event for early media. Using the existing Newstate event with a "faked" state called "progress".
In the long run, this is not the right thing to do, but after discussion with Russell on asterisk-dev it was concluded that it was the easiest way forward.
This addresses bug 19135.
https://issues.asterisk.org/jira/browse/19135
Diffs (updated)
-----
/team/oej/bring-in-the-early-media-trunk/apps/app_dial.c 332755
/team/oej/bring-in-the-early-media-trunk/main/pbx.c 332755
Diff: https://reviewboard.asterisk.org/r/1187/diff
Testing
-------
Tested many calls in the 1.4 version of the same patch.
One-legged calls using the progress() dialplan app, two legged calls using dial().
Thanks,
Olle E
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110919/aedffdb3/attachment.htm>
More information about the asterisk-dev
mailing list