[asterisk-dev] [Code Review] Plenty of review done - Set channel variables with setvar= when manager user originates calls

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1412/#review4351
-----------------------------------------------------------



/trunk/CHANGES
<https://reviewboard.asterisk.org/r/1412/#comment8464>

    Blob



/trunk/configs/manager.conf.sample
<https://reviewboard.asterisk.org/r/1412/#comment8465>

    Blobbity



/trunk/include/asterisk/config.h
<https://reviewboard.asterisk.org/r/1412/#comment8466>

    I know, I hate it when spaces cause blobs



/trunk/main/config.c
<https://reviewboard.asterisk.org/r/1412/#comment8467>

    Red ink



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/1412/#comment8463>

    I'm confused how this doesn't leak memory.  I understand that tmpvar is chained onto user->chanvars, but where is user->chanvars ever freed?  Unless I'm missing something, it isn't deallocated when the user->keep field isn't set (see line 6761) - so when the user itself is deallocated in 6788, the memory pointed to by your chain is left.
    


- mjordan


On Sept. 15, 2011, 10:11 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1412/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2011, 10:11 a.m.)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> When the manager originates calls, there's no way to add channel variables. THis patch adds a setvar= option in manager.conf for a specific account, much like in sip.conf
> 
> This is different form variables in the originate in that these are set on every call, regardless of settings in the manager client software. Good for usage in combination with the manager event filters.
> 
> 
> This addresses bug 18143.
>     https://issues.asterisk.org/jira/browse/18143
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 336090 
>   /trunk/Makefile 336090 
>   /trunk/configs/manager.conf.sample 336090 
>   /trunk/include/asterisk/config.h 336090 
>   /trunk/main/config.c 336090 
>   /trunk/main/manager.c 336090 
> 
> Diff: https://reviewboard.asterisk.org/r/1412/diff
> 
> 
> Testing
> -------
> 
> In-house testing while developing. Channel variables added (proved by dumpchan() )
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110916/9549f8d1/attachment.htm>