[asterisk-dev] [Code Review]: Asterisk 1.8 Deadlock in app_queue

[irroot]

> On Sept. 14, 2011, 1:53 p.m., Matthew Nicholson wrote:
> > This looks ok to me. Please continue to test it as much as possible. Let me know when you think it is ready and we'll get it committed.

Put this in production at some heavier sites and there no ill effects at all.


- irroot


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1402/#review4333
-----------------------------------------------------------


On Sept. 14, 2011, 1:31 p.m., irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1402/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2011, 1:31 p.m.)
> 
> 
> Review request for Asterisk Developers and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> Locking order with queues container.
> 
> 1)the queues container is locked when calling channels this causes a deadlock and is unneeded.
> 2)lock the queues container when running queue_update to maintain correct locking order.
> 
> 
> This addresses bug ASTERISK-18101.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18101
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_queue.c 335789 
> 
> Diff: https://reviewboard.asterisk.org/r/1402/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110915/5d1c6990/attachment.htm>