[asterisk-dev] [Code Review] SIP Dialog pre- / post-test condition checking

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1437/#review4335
-----------------------------------------------------------



/asterisk/team/mjordan/test_conditions/trunk/lib/python/asterisk/SipDialogTestCondition.py
<https://reviewboard.asterisk.org/r/1437/#comment8426>

    This will cause tests that only check for registration or invites to fail.  If we want SIP checking to include entries in the history beyond scheduled destruction, it will need to be configurable.


- mjordan


On Sept. 14, 2011, 1:46 p.m., mjordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1437/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2011, 1:46 p.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> This adds the ability to check for SIP dialogs before and after a test run.  Before a test run, the presence of any SIP dialogs is treated as a test failure.  After a test run, SIP dialogs are allowed to exist, as they will most likely be scheduled for deletion (which could be up to 32 seconds after the test has completed executing).  However, the SIP history is checked for each present dialog to ensure that the SIP dialog includes a hangup, and that it was scheduled for destruction with the scheduler.
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/mjordan/test_conditions/trunk/lib/python/asterisk/SipDialogTestCondition.py PRE-CREATION 
>   /asterisk/team/mjordan/test_conditions/trunk/tests/apps/voicemail/authenticate_nominal/test-config.yaml 2207 
>   /asterisk/team/mjordan/test_conditions/trunk/tests/apps/voicemail/check_voicemail_new_user/test-config.yaml 2207 
>   /asterisk/team/mjordan/test_conditions/trunk/tests/apps/voicemail/check_voicemail_nominal/test-config.yaml 2207 
>   /asterisk/team/mjordan/test_conditions/trunk/tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml 2207 
> 
> Diff: https://reviewboard.asterisk.org/r/1437/diff
> 
> 
> Testing
> -------
> 
> Local machine, including unit tests for parsing of Asterisk CLI responses.
> 
> 
> Thanks,
> 
> mjordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110914/7d6a6a46/attachment-0001.htm>