[asterisk-dev] [Code Review] Asterisk 1.8 Deadlock in app_queue

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1402/
-----------------------------------------------------------

(Updated Sept. 14, 2011, 6:08 a.m.)


Review request for Asterisk Developers and Matthew Nicholson.


Changes
-------

Ok this should be about it i have added the queues lock back in the reload function where the queues container is held while the config is reloaded. this is a saner approach.

the ao2_callback functions used now have the NOLOCK flag to do it taking this into account.

Removed some red blocks left by the crayola kiddies.


Summary
-------

Locking order with queues container.

1)the queues container is locked when calling channels this causes a deadlock and is unneeded.
2)lock the queues container when running queue_update to maintain correct locking order.


This addresses bug ASTERISK-18101.
    https://issues.asterisk.org/jira/browse/ASTERISK-18101


Diffs (updated)
-----

  /branches/1.8/apps/app_queue.c 335786 

Diff: https://reviewboard.asterisk.org/r/1402/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110914/1cb1ec4c/attachment.htm>