[asterisk-dev] [Code Review]: Clean up cel.conf parsing

[Paul Belanger]

> On Sept. 13, 2011, 3:31 p.m., Paul Belanger wrote:
> > trunk/cel/cel_manager.c, lines 129-132
> > <https://reviewboard.asterisk.org/r/1436/diff/1/?file=20584#file20584line129>
> >
> >     I actually like this logic but decided to remove it for now.  I'm going see about creating an ast_variable_unknown() function for the logging.
> 
> rmudgett wrote:
>     There are pros and cons to generating this message.  It depends on how the configuration options are processed in a module.
>     * It helps you find typo's.
>     * It is annoying when you change Asterisk versions and know that it is not available in a particular version.

Right, I do see the benefit for the first point made. I've recently made typos in config files and could use it.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1436/#review4324
-----------------------------------------------------------


On Sept. 13, 2011, 3:29 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1436/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2011, 3:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This includes both [general] and [manager] sections for cel.conf.  We also no longer fail to load the module when the configuration file is missing, it will now use the defaults.
> 
> 
> Diffs
> -----
> 
>   trunk/main/cel.c 335603 
>   trunk/cel/cel_manager.c 335603 
> 
> Diff: https://reviewboard.asterisk.org/r/1436/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110913/589af66a/attachment-0001.htm>