[asterisk-dev] [Code Review]: Adding the PICKUPSTATUS variable

[Alec Davis]

> On Sept. 11, 2011, 3:41 p.m., Alec Davis wrote:
> > refer https://reviewboard.asterisk.org/r/1217/

The dialplan will not continue if the pickup was a success.
Either set the $(PICKUPSTATUS} as Richard Mudgett sugessted in RB1212 before calling Pickup(), or assume that the pickup has failed if you get past the Pickup().
> 
> rmudgett wrote:
>     Thank you Alec.  This review needs to be marked as discarded as it no longer applies and also is not needed.

Perhaps the only change is the removal of the 'To Do' that suggests that '$PICKUPSTATUS' result needs to be added. 


- Alec


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1073/#review4288
-----------------------------------------------------------


On Jan. 9, 2011, 9:13 a.m., junky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1073/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2011, 9:13 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When using the Pickup() application, it's sometime really important to know if the Pickup worked or not.
> 
> That patch adds this functionality.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_directed_pickup.c 301175 
> 
> Diff: https://reviewboard.asterisk.org/r/1073/diff
> 
> 
> Testing
> -------
> 
> tested with Pickup()
> tested with @PICKUPMARK
> 
> 
> Thanks,
> 
> junky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110913/389a9514/attachment.htm>