[asterisk-dev] [Code Review] fix so func_curl hashcompat can handle comma's in keys/values

Tilghman Lesher reviewboard at asterisk.org
Tue Sep 13 12:26:39 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1433/#review4316
-----------------------------------------------------------

Ship it!


There's something to be said about people who put commas in field names, which cannot be repeated in polite company.  ;-)

- Tilghman


On Sept. 13, 2011, 10:22 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1433/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2011, 10:22 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> CURLOPT(hashcompat) can return the abc=def&ghi=jkl values from a curl requests as an associative ${HASH}.
> 
> It breaks on comma's.
> 
> This small fix is copied directly from func_realtime.
> 
> (Forget diff1, some other stuff got included.)
> 
> 
> Diffs
> -----
> 
>   branches/1.8/funcs/func_curl.c 335557 
> 
> Diff: https://reviewboard.asterisk.org/r/1433/diff
> 
> 
> Testing
> -------
> 
> Tested on 1.6.2. Should work on 1.8 and trunk too.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110913/9629bffa/attachment.htm>


More information about the asterisk-dev mailing list