[asterisk-dev] [Code Review]: Iterate over the [csv] section of cdr.conf

[Paul Belanger]

> On Sept. 12, 2011, 2:30 a.m., wdoekes wrote:
> > All those if (someoption) { ast_debug(...); } can become confusing now.
> > 
> > If I do:
> > usegmtime=yes
> > usegmtime=no
> > 
> > DEBUG will tell that I'm using gmtime, while I'm not.
> > 
> > Suggest: add } else { ast_debug("not using XYZ"); }

Agree, I'd rather just remove the statements completely.  Or add something after the iteration.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1427/#review4290
-----------------------------------------------------------


On Sept. 11, 2011, 10:21 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1427/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2011, 10:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a continuation of review 1426[1] but for the [csv] section of cdr.conf. Rather then one big patch, they have been broken into smaller ones.
> 
> [1] https://reviewboard.asterisk.org/r/1426/
> 
> 
> Diffs
> -----
> 
>   trunk/UPGRADE.txt 335212 
>   trunk/cdr/cdr_csv.c 335212 
> 
> Diff: https://reviewboard.asterisk.org/r/1427/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110912/62576d2e/attachment.htm>