[asterisk-dev] [Code Review] Add a SIPpeerstatus command to chan_sip's manager interface.

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1098/#review3176
-----------------------------------------------------------

Ship it!


Good addition from an architecture standpoint. Just an extra idea to implement: Regexp matching. If I have multiple groups of users I usually group them ny name.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1098/#comment6565>

    Formatting, formatting :-)



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1098/#comment8383>

    WOuld it be a nice feature to be able to send a regexp heer, like "sip show peer like "? I think so. 


- Olle E


On Sept. 12, 2011, 8:54 a.m., Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1098/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 8:54 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds a SIPpeerstatus command to chan_sip's manager interface that will generate PeerStatus events similar to the existing PeerStatus events found in chan_sip but containing current peer status.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 335322 
> 
> Diff: https://reviewboard.asterisk.org/r/1098/diff
> 
> 
> Testing
> -------
> 
> Tested an old version of the patch by using the SIPpeerstatus command (it has been sitting on my system for a while), worked fine then.
> 
> 
> Thanks,
> 
> Matthew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110912/dd0287d6/attachment.htm>