[asterisk-dev] [Code Review] Set default tonezone for SIP devices

Olle E Johansson reviewboard at asterisk.org
Mon Sep 12 07:38:19 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1429/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

When using Asterisk with users in multiple countries it's important to be able to set default tone zone for calls related to the devices. This patch adds a setting called "tonezone" to sip.conf [general] and device sections.

The reason why I keep the zone as a text string in the peer and dialogs is that indications can change while asterisk is running. I decided to convert it to an actual channel tone zone indication when the channel was created and not keep it in the peer structure.


This addresses bug ASTERISK-18497.
    https://issues.asterisk.org/jira/browse/ASTERISK-18497


Diffs
-----

  /trunk/channels/chan_sip.c 335252 
  /trunk/channels/sip/include/sip.h 335252 
  /trunk/configs/sip.conf.sample 335252 
  /trunk/include/asterisk/indications.h 335252 

Diff: https://reviewboard.asterisk.org/r/1429/diff


Testing
-------

Locally. Works. 


Thanks,

Olle E

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110912/1dddc09e/attachment-0001.htm>


More information about the asterisk-dev mailing list