[asterisk-dev] [Code Review] TestCase.ami_connect clean up

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1425/#review4277
-----------------------------------------------------------

Ship it!


One less line of code to add in every test, great!

- mjordan


On Sept. 9, 2011, 4:22 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1425/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2011, 4:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Some code clean up around the TestCase.ami_connect method.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/apps/directory_attendant_exit/run-test 2165 
>   asterisk/trunk/tests/apps/directory_context_operator_exit/run-test 2165 
>   asterisk/trunk/tests/apps/directory_operator_exit/run-test 2165 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/run-test 2165 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/run-test 2165 
>   asterisk/trunk/lib/python/asterisk/TestCase.py 2165 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/run-test 2165 
>   asterisk/trunk/tests/apps/voicemail/func_vmcount/run-test 2165 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test 2165 
>   asterisk/trunk/tests/callparking/run-test 2165 
>   asterisk/trunk/tests/cdr/console_dial_sip_answer/run-test 2165 
>   asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/run-test 2165 
>   asterisk/trunk/tests/channels/SIP/sip_tls_call/run-test 2165 
>   asterisk/trunk/tests/directed_pickup/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_g711_t38/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_mix1/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_mix2/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_mix3/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_mix4/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_native_t38/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_native_t38_ced/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_no_t38/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_t38_g711/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_timeout1/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_timeout2/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_timeout3/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_timeout4/run-test 2165 
>   asterisk/trunk/tests/fax/gateway_timeout5/run-test 2165 
>   asterisk/trunk/tests/func_srv/run-test 2165 
>   asterisk/trunk/tests/manager/login/run-test 2165 
>   asterisk/trunk/tests/pbx/merge_contexts/run-test 2165 
>   asterisk/trunk/tests/pbx/pbx_lua_background/run-test 2165 
>   asterisk/trunk/tests/pbx/pbx_lua_goto/run-test 2165 
>   asterisk/trunk/tests/regressions/M18882/run-test 2165 
>   asterisk/trunk/tests/udptl/run-test 2165 
> 
> Diff: https://reviewboard.asterisk.org/r/1425/diff
> 
> 
> Testing
> -------
> 
> Local development box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110909/93fc2aa0/attachment.htm>