[asterisk-dev] [Code Review] Remove the use of queue_member uniqueid

Tilghman Lesher reviewboard at asterisk.org
Thu Sep 8 15:13:13 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1422/
-----------------------------------------------------------

Review request for Asterisk Developers and Leif Madsen.


Summary
-------

There exists a field in the queue_members table which is used solely for updating, which we have long ago amended the need for, by the use of the ast_update2_realtime() function.  This patch transitions Asterisk away from using that field internally, just as has already been done with app_voicemail.

Additionally, while reviewing the contributed realtime fields to remove mention of this now unneeded field, I happened upon some realtime fields in the queue_members table that were not yet documented.  I have added these fields in this patch, for completeness.

Discussed with lmadsen on #asterisk-bugs in relation to ASTERISK-18480, now closed as not a bug.


Diffs
-----

  /trunk/apps/app_queue.c 334573 
  /trunk/contrib/realtime/mysql/queue_members.sql PRE-CREATION 
  /trunk/contrib/realtime/mysql/queues.sql PRE-CREATION 
  /trunk/contrib/realtime/postgresql/realtime.sql 334574 

Diff: https://reviewboard.asterisk.org/r/1422/diff


Testing
-------


Thanks,

Tilghman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110908/70b0eb80/attachment.htm>


More information about the asterisk-dev mailing list