[asterisk-dev] [Code Review] Add option to automatically pause a busy queue member

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1399/#review4251
-----------------------------------------------------------

Ship it!


This is a useful option and unobtrusive.

Like it thx nice one.

- irroot


On Sept. 6, 2011, 6:25 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1399/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2011, 6:25 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Long ago, autopause used to also affect busy queue members. That behavior was changed. In some situations, it is conceivable that the old behavior might want to be retained. This patch adds the autopausebusy option to allow this behavior.
> 
> As an example: 
> If queue members are not allowed to make outbound calls, then the only calls that they receive will be from the Queue. The devices should be marked properly as IN USE when a call is in progress. But, if a queue member sets their phone to DND, it will respond as though it is busy even though it is not in use. Having the phone automatically paused in this case would make the phone then unavailable and settings like leave/joinwhenempty behave as expected. When the user is no longer on DND, they can unpause themselves.
> 
> NOTE: Asterisk currently will treat SIP responses 486, 600, and 603 as busy. Many phones send one of these responses for being on DND. Some send a 480 Temporarily Unavailable which Asterisk treats as CONGESTION. There are several different meanings that could be attached to a 480, so whether or not we should treat it as a BUSY instead is a topic for debate and could be addressed separately, but if we don't make it a BUSY condition then perhaps an "autopausecondition=busy|congestion option might be appropriate). See http://tools.ietf.org/html/draft-elwell-bliss-dnd-01#section-5.1 for some discussion of the DND issue.
> 
> 
> This addresses bug ASTERISK-16112.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16112
> 
> 
> Diffs
> -----
> 
>   /branches/10/CHANGES 334572 
>   /branches/10/apps/app_queue.c 334572 
>   /branches/10/configs/queues.conf.sample 334572 
> 
> Diff: https://reviewboard.asterisk.org/r/1399/diff
> 
> 
> Testing
> -------
> 
> Set phone to DND, called queue with an unpaused member. Verified that the member became paused after first call attempt.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110907/49aee316/attachment-0001.htm>