[asterisk-dev] [Code Review] No review yet - Set channel variables with setvar= when manager user originates calls

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1412/
-----------------------------------------------------------

(Updated Sept. 6, 2011, 9:35 a.m.)


Review request for Asterisk Developers and Tilghman Lesher.


Changes
-------

Thanks to Kevin for fixing the sync between our svn servers I can now offer the actual code for review, not just the appetizer.


Summary (updated)
-------

When the manager originates calls, there's no way to add channel variables. THis patch adds a setvar= option in manager.conf for a specific account, much like in sip.conf

This is different form variables in the originate in that these are set on every call, regardless of settings in the manager client software. Good for usage in combination with the manager event filters.


This addresses bug 18143.
    https://issues.asterisk.org/jira/browse/18143


Diffs (updated)
-----

  /trunk/include/asterisk/config.h 334444 
  /trunk/main/config.c 334444 
  /trunk/main/manager.c 334444 

Diff: https://reviewboard.asterisk.org/r/1412/diff


Testing
-------

In-house testing while developing. Channel variables added (proved by dumpchan() )


Thanks,

Olle E

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110906/9591f630/attachment.htm>