[asterisk-dev] [Code Review]: Allow codecs to be negated in allow and disallow lines.

[Tilghman Lesher]

> On Sept. 5, 2011, 2:25 a.m., Olle E Johansson wrote:
> > Will this only affect realtime or also the text based configuration?
> > 
> > If text based configuration is affected, we should update the sample configurations. Maybe even consider skipping the allow/disallow to only make a single line configuration. The allow/disallow and permit/deny makes life hard both for realtime and while training - they kind of break the concept.

This affects both configurations, so yes, we could considerably simplify the existing sample configuration.  While I'm sure we could do the same for permit/deny, due to the length of those arguments, I'm not sure it makes the syntax clearer.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1411/#review4222
-----------------------------------------------------------


On Sept. 3, 2011, 5:25 p.m., Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1411/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2011, 5:25 p.m.)
> 
> 
> Review request for Asterisk Developers and Terry Wilson.
> 
> 
> Summary
> -------
> 
> As discussed on the SQLite3 realtime driver, add the '!' to negate terms when specifying allowed and disallowed codecs.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 334235 
>   /trunk/main/frame.c 334235 
> 
> Diff: https://reviewboard.asterisk.org/r/1411/diff
> 
> 
> Testing
> -------
> 
> Tried multiple codec specifications, both with 'all' as well as '!all', and it works as designed.
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110905/97e5cbfa/attachment.htm>