[asterisk-dev] [Code Review]: log Asterisk Version number, Build etc into log file

[Olle E Johansson]

> On Sept. 3, 2011, 10:08 a.m., lathama wrote:
> > I like it.  Appears almost too simple for a review.  I would add or make an option to add this to the debug or other logs.
> 
> Alec Davis wrote:
>     With that thought, I've had a quick look at logger.c with the intention of putting the Version+Build etc on every logger file as it's opened.
>     
>     Ideally then when 'logger rotate' is issued the new files will also have the version number as the first line.
> 
> lathama wrote:
>     Wonderful thought...  Do you have a diff ready or need some help?

I prefer having the time stamp included in the log line - also a way to catch reboots.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1409/#review4211
-----------------------------------------------------------


On Sept. 5, 2011, 4:20 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1409/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2011, 4:20 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When the question is asked what was the last version that worked? You'd of thought looking through the logs it would be reported.
> 
> 
> Diffs
> -----
> 
>   trunk/main/logger.c 333893 
> 
> Diff: https://reviewboard.asterisk.org/r/1409/diff
> 
> 
> Testing
> -------
> 
> asterix:/var/log/asterisk# head messages
> Asterisk SVN-trunk-r333838M built by root @ asterix on a i686 running Linux on 2011-05-27 11:52:02 UTC
> [2011-09-05 21:13:25.672533] NOTICE[27089] loader.c: 1 modules will be loaded.
> [2011-09-05 21:13:25.693952] WARNING[27089] http.c: Got 1 addresses
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110905/757040fe/attachment.htm>