[asterisk-dev] [Code Review]: Additional tests for app_voicemail

mjordan reviewboard at asterisk.org
Fri Sep 2 11:39:46 CDT 2011



> On Sept. 1, 2011, 5:33 p.m., Paul Belanger wrote:
> > asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/run-test, line 302
> > <https://reviewboard.asterisk.org/r/1360/diff/3/?file=19718#file19718line302>
> >
> >     not need, we already log in from TestCase.ami_connect()

Yeah, that really was for debugging at one point when I wasn't coming out of TestCase.ami_connect.  It can be removed.


> On Sept. 1, 2011, 5:33 p.m., Paul Belanger wrote:
> > asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/run-test, line 303
> > <https://reviewboard.asterisk.org/r/1360/diff/3/?file=19718#file19718line303>
> >
> >     I believe we want to be calling VoiceMailTest.ami_connect() otherwise we are skipping that object.
> >     
> >     
> >     On thing I was looking into was using the super() method.

Not a problem here, since VoiceMailTest doesn't override ami_connect.  Not explicitly defining the superclass is probably better however and should be used throughout - we should probably encourage that.


> On Sept. 1, 2011, 5:33 p.m., Paul Belanger wrote:
> > asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/run-test, lines 378-380
> > <https://reviewboard.asterisk.org/r/1360/diff/3/?file=19718#file19718line378>
> >
> >     same comment about moving it into VoiceMailTest

Maybe.  If a subclass needed to create a different number of AMI factories (or not create any) than they would want to do that - which is the reason for having this here - func_vmcount being one of the tests that only creates one (although it doesn't currently inherit from VoiceMailTest, so that's not an issue).  I'll see about moving it down.


> On Sept. 1, 2011, 5:33 p.m., Paul Belanger wrote:
> > asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/run-test, lines 34-58
> > <https://reviewboard.asterisk.org/r/1360/diff/3/?file=19742#file19742line34>
> >
> >     I'm not 100%, but this class looks to be copied multiple places?

A lot of the test state classes are replicated.  That's not always ideal, but each test state class defines the actions that a test should take when in that state for that particular test.  In this case, StartVoiceMailState handles getting the user to the authenticated state, and so the (vast) majority of tests always do the same thing.  So yes, that's repeated.

But in the case where you want authentication to fail, you would change the implementation of handleStateChange to send the wrong mailbox or password (or just behave badly).  I had written the authenticate tests before all this infrastructure existed, so they do it a bit differently currently.

This already has a base class (all test states inherit from VoiceMailState, which inherits from TestState); I thought at one point about going further and making this yet another superclass with additional subclasses overriding it further and having those change the mailbox / password member variables, but there's not much gained from that.  Right now, the class state definitions being with the test classes clearly define what is going to occur in a test - putting this into the library implies that *all* tests, regardless of what they do, would want to use this, and that's not the case.

It just happens to be the case right now :-)


> On Sept. 1, 2011, 5:33 p.m., Paul Belanger wrote:
> > asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/configs/ast1/manager.users.conf.inc, lines 1-2
> > <https://reviewboard.asterisk.org/r/1360/diff/3/?file=19711#file19711line1>
> >
> >     Why is this needed?

Needed to add the 'test' manager event to the read / write permissions.  This should be moved to the default manager.users.conf however.


> On Sept. 1, 2011, 5:33 p.m., Paul Belanger wrote:
> > asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/run-test, line 299
> > <https://reviewboard.asterisk.org/r/1360/diff/3/?file=19718#file19718line299>
> >
> >     I don't think we need to create 2 instances of asterisk for the majority of these test.  I single instance with chan_local _should_ be more then enough.  
> >     
> >     
> >     Additionally, we could likely move this logic into the VoiceMailTest class; avoiding code duplication in other tests.

Not all instances did create two asterisk instances - a few only needed one (func_vmcount for example).  But, I agree, chan_local should do it.  I'll see if that works, if so I'll update the tests and repost a diff.


> On Sept. 1, 2011, 5:33 p.m., Paul Belanger wrote:
> > asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/run-test, lines 347-352
> > <https://reviewboard.asterisk.org/r/1360/diff/3/?file=19718#file19718line347>
> >
> >     we can move this into VoiceMailTest class.  It looks the same for other tests.

Agreed.


- mjordan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1360/#review4203
-----------------------------------------------------------


On Aug. 29, 2011, 2:48 p.m., mjordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1360/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2011, 2:48 p.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> [Edit] - Due to a significant number of changes in the testsuite libraries, all voicemail tests were updated.  They are available for test and review on the team branch mjordan/voicemail_tests_082811/.
> 
> The following tests for are for the following app_voicemail applications:
>   VoiceMail - checking extension routing, priority message leaving, message forwarding, and external notifications
>   VMCOUNT - function that uses several app_voicemail methods for counting inbox messages
>   VMAuthenticate - mailbox / password authentication
>   VoiceMailMain - tests for various menus, advanced options, simultaneous access of mailbox with caller, changing greetings, new user, external apps, and automatic exits
> 
> Features that are covered by these tests are documented at https://wiki.asterisk.org/wiki/display/~mjordan/Voicemail+Refactoring - although this is a draft document and should not be taken as cannon.
> 
> Note that currently, leave_voicemail_contexts, leave_voicemail_forwarding, and leave_voicemail_forwarding_auto_urgent are expected to fail and are noted as such with the ASTERISK bugs that were filed.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/lib/python/asterisk/TestCase.py 2020 
>   asterisk/trunk/lib/python/asterisk/TestState.py PRE-CREATION 
>   asterisk/trunk/lib/python/asterisk/voicemail.py 2020 
>   asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_extensions/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_extensions/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/authenticate_nominal/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/voicemailpwcheck.py PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/voicemailpwnotify.py PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast2/manager.users.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/func_vmcount/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/func_vmcount/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/func_vmcount/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/func_vmcount/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/func_vmcount/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/extern-notify-script.py PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test 2020 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast1/voicemail.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/run-test PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/apps/voicemail/tests.yaml 2020 
> 
> Diff: https://reviewboard.asterisk.org/r/1360/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> mjordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110902/8f4aad18/attachment-0001.htm>


More information about the asterisk-dev mailing list