[asterisk-dev] [Code Review] Prevent segfault when asterisk restarts. Happens if call arrives before fully booted.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1407/#review4207
-----------------------------------------------------------



trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/1407/#comment8252>

    Now that I look at this again, this check should be done in the same places that increase_call_count() is called.
    
    Also the callers of ast_pbx_start(), ast_pbx_run_args(), and ast_pbx_run() need to be checked that they check the return value and hangup the channel appropriately when they fail.


- rmudgett


On Sept. 2, 2011, 3:25 p.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1407/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2011, 3:25 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> If a call arrives before asterisk is fully booted generally it will segfault.
> 
> 
> Diffs
> -----
> 
>   trunk/main/pbx.c 333893 
> 
> Diff: https://reviewboard.asterisk.org/r/1407/diff
> 
> 
> Testing
> -------
> 
> restarted asterisk, and before all modules have finished loading made a call into it.
> Warnign message appears, and call is dropped.
> No orpaned channels.
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110902/1f9b9e07/attachment-0001.htm>