[asterisk-dev] [Code Review] app_queue change to have one devstate per device not per member / Janitorial cleanups

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1538/
-----------------------------------------------------------

(Updated Oct. 28, 2011, 12:20 p.m.)


Review request for Asterisk Developers and Matthew Nicholson.


Changes
-------

Combine the 5 Dynamic/Realtime methods of adding a queue member into one function.
ASTDB / CLI / AMI / RT / APP AddQueueMember

There is a nasty mem leak introduced by myself fixed in this version 

the static member config is due to be merged with this one member handling function.

I also want to be flaging what gets loaded when if the queue is in memory and the "meat" is not 
needed then dont look up the settings same applies to members if im not working with all members
dont load them all this should improve performance.


Summary
-------

This is a rather large changeset but consists of the following

1)rework adding member records combine duplicate code
2)remove check_state_unknown its not needed any more now that we can reserve a state interface
3)split state information into a new container (devices) the member holds a ref to it allowing shared state devices see above
4)realtime and paused are y/n so add a :1 to them and align bitfields in struct

5)ao2 search callbacks can handle non OBJ_POINTER flag to make ao2_find useful no need to pass obj
6)Reservation of devices to pervent duplicate calls


This addresses bug AST-695.
    https://issues.asterisk.org/jira/browse/AST-695


Diffs (updated)
-----

  /trunk/apps/app_queue.c 342566 

Diff: https://reviewboard.asterisk.org/r/1538/diff


Testing
-------

as most of the above [1,2,4] are removing code not referenced or changing syntax going over the .diff over and over makeing sure it builds and loads.

check state information is propogated and used in app_queue [3,6] 
make sure queues are loaded correctly and changes in [5] have not broken things

backport of app_queue[trunk] to 1.8 [production] has been running 4k+ calls per day for 2 days on this patch.


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111028/c8492488/attachment.htm>