[asterisk-dev] [Code Review] Implement Externaddr on a sip device basis

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1471/#review4599
-----------------------------------------------------------


Looks fine. A couple of minor points:


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1471/#comment8774>

    ast_sockaddr_stringify uses a static buffer: ast_strdupa()



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1471/#comment8775>

    tiny red blob



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1471/#comment8777>

    Why is an empty externaddr= setting now allowed without warning? It doesn't seem consistent with the other settings. Or does this serve a purpose I don't see?


- wdoekes


On Sept. 29, 2011, 7:14 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1471/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 7:14 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, the Asterisk SIP channel can only handle one externaddr per host. With this patch, every peer can have a externaddr setting so that we can have different externaddr for different SIP trunks.
> 
> 
> This addresses bug ASTERISK-18643.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18643
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 338415 
>   /trunk/channels/chan_sip.c 338373 
>   /trunk/channels/sip/include/sip.h 338373 
>   /trunk/configs/sip.conf.sample 338373 
> 
> Diff: https://reviewboard.asterisk.org/r/1471/diff
> 
> 
> Testing
> -------
> 
> The 1.4 version has been in production for about a year in a large call center.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111027/1472ba37/attachment-0001.htm>