[asterisk-dev] [Code Review] Clean up reference leaks in res_jabber

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1478/
-----------------------------------------------------------

(Updated Oct. 26, 2011, 2:57 p.m.)


Review request for Asterisk Developers and Tilghman Lesher.


Changes
-------

Made suggested change. Nice catch.


Summary
-------

I'm pretty sure there are object reference leaks throughout res_jabber and this patch is meant to clear some of those.  I'm still a little inexperienced in this area though, so I could definitely use a second pair of eyes to make sure this is all appropriate.


Diffs (updated)
-----

  /branches/1.8/res/res_jabber.c 342539 

Diff: https://reviewboard.asterisk.org/r/1478/diff


Testing
-------

I'm absolutely sure the one involved with devstate publishing is getting leaked because I could publish devstates multiple times in a row and every time once the operation was over, the reference count would be one higher.  I'm not 100% sure on the others since I didn't individually test them, but the idea seems the same and all of these ASTOBJ_REF calls were added around the same time by Tilghman, so it seems like it would be a consistent problem.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111026/657bf0e4/attachment-0001.htm>