[asterisk-dev] [Code Review] ConfBridge User Announce Feature Set

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1011/#review4579
-----------------------------------------------------------


The way that options are specified for ConfBridge in Asterisk 10 and trunk has changed considerably.  Almost all options are setup in confbridge.conf on a per-user or per-bridge basis or are settable in the dialplan on the fly.  The 'i' option is already taken care of by "announce_join_leave", but this does not include name review ('I') or the ability to pull the name from the voicemail box ('h').  Please update this patch to work with trunk.

- opticron


On Jan. 10, 2011, 4:41 p.m., Andrew Parisio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1011/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2011, 4:41 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I copied the i and I features from meetme, as well as the same h functionality I posted in reviewboard 1009.  
> 
> I noticed I could cause a segfault if I called in from extension 1, then called in from extensions 2 and 3 at the exact same time but they had to be almost identically timed.  This didn't seem to happen in the trunk version so I think it's part of this patch.  I'm not sure if it's related to one of the locks on the bridge but I'm hoping somebody that is more knowledgeable about ConfBridge may be able to help there.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_confbridge.c 299310 
> 
> Diff: https://reviewboard.asterisk.org/r/1011/diff
> 
> 
> Testing
> -------
> 
> ConfBridge(1,i)
> ConfBridge(1,I)
> ConfBridge(1,h(1593 at default))
> 
> 
> Thanks,
> 
> Andrew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111025/52724906/attachment-0001.htm>