[asterisk-dev] [Code Review]: fopen(REF_FILE) fails to check for success

[Tilghman Lesher]

> On Oct. 25, 2011, 10:03 a.m., rmudgett wrote:
> > /trunk/main/astobj2.c, lines 327-334
> > <https://reviewboard.asterisk.org/r/1539/diff/3/?file=21381#file21381line327>
> >
> >     Good change.  It avoids opening the file if the alloc failed.

Might make sense to move the declaration and initialization down to within the conditional, so that the code mirrors the other places within this source file.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1539/#review4572
-----------------------------------------------------------


On Oct. 25, 2011, 3:24 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1539/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2011, 3:24 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I sometimes switch between running asterisk as user and root. When refcounting is enabled, asterisk crashes when trying to fprintf to a NULL FILE* when it cannot fopen /tmp/refs.
> 
> I didn't go for fancy error checking and warnings: just checking for writability is fine for my purposes. The refcounting user should be smart enough to check for file permissions when the file stays empty.
> 
> (Second diff removes a red blob.)
> 
> 
> Diffs
> -----
> 
>   /trunk/main/astobj2.c 342060 
> 
> Diff: https://reviewboard.asterisk.org/r/1539/diff
> 
> 
> Testing
> -------
> 
> It works.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111025/c1f9eb23/attachment-0001.htm>