[asterisk-dev] [Code Review] fopen(REF_FILE) fails to check for success

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1539/
-----------------------------------------------------------

(Updated Oct. 25, 2011, 3:24 a.m.)


Review request for Asterisk Developers.


Changes
-------

Richards comments.


Summary
-------

I sometimes switch between running asterisk as user and root. When refcounting is enabled, asterisk crashes when trying to fprintf to a NULL FILE* when it cannot fopen /tmp/refs.

I didn't go for fancy error checking and warnings: just checking for writability is fine for my purposes. The refcounting user should be smart enough to check for file permissions when the file stays empty.

(Second diff removes a red blob.)


Diffs (updated)
-----

  /trunk/main/astobj2.c 342060 

Diff: https://reviewboard.asterisk.org/r/1539/diff


Testing
-------

It works.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111025/def0bde7/attachment-0001.htm>