[asterisk-dev] [Code Review]: Make sure the member count is correct after a reload

[Terry Wilson]

> On Oct. 24, 2011, 7:30 p.m., rmudgett wrote:
> > /branches/1.8/apps/app_queue.c, lines 6611-6615
> > <https://reviewboard.asterisk.org/r/1541/diff/1/?file=21338#file21338line6611>
> >
> >     You must keep the unref of cur because ao2_find still returns a ref to the found object even though it was unlinked from the container.

Doh, I fixed this a couple of different times and must have accidentally deleted that on the last one. How silly. I suppose that is what reviews are for.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1541/#review4568
-----------------------------------------------------------


On Oct. 24, 2011, 5:20 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1541/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2011, 5:20 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> With the situation:
> queues.conf
> [test]
> strategy=ringall
> member => Local/queue1 at default,1
> member => Local/queue2 at default,1
> member => Local/queue3 at default,1
> 
> extensions.conf
> [default]
> exten => 100,1,Queue(test)
> exten => _queueX,1,NoOp(Called ${EXTEN})
> same => n,Ringing
> same => n,Wait(5)
> same => n,Hangup
> 
> Dialing 100 will ring all queue members. Changing the penalty of two of the members and doing a 'module reload app_queue.so' and redialing would still ring all of the members on the first try instead of just the lowest penalty member. This was because a reload would set the membercount to 0 and then only increase the membercount for *new* members and not reloaded members. Then, since the penaltymemberlimit = 0 and the membercount = 0, we ignored the penalties and would dial all members.  This patch increases the member count for both reloaded and added members since we set the member count to zero on reloads anyway.
> 
> 
> This addresses bug AST-676.
>     https://issues.asterisk.org/jira/browse/AST-676
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_queue.c 342060 
> 
> Diff: https://reviewboard.asterisk.org/r/1541/diff
> 
> 
> Testing
> -------
> 
> Fixes the above scenario.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111025/3cbe073d/attachment.htm>