[asterisk-dev] [Code Review] Fix several bugs with SDP parsing and well-formedness of responses

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1516/
-----------------------------------------------------------

(Updated Oct. 24, 2011, 5:10 p.m.)


Review request for Asterisk Developers.


Changes
-------

Removed some dead code that was wrong anyway and change the name of the "offered" member variable to be more descriptive.  I'm going to give this a little more time before committing for feedback.


Summary
-------

Fix bug ASTERISK-16558 which dealt with the order of responses to incoming streams defined by SDP.

Fix unreported bug where offering multiple same-type streams would cause Asterisk to reply with an incorrect SDP response missing one or more streams without a proper declination.

Fix bugs related to a single non-audio stream being offered with responses requesting codecs that were not offered in the initial invite along with an additional audio stream that was not in the initial invite.


This addresses bug ASTERISK-16558.
    https://issues.asterisk.org/jira/browse/ASTERISK-16558


Diffs (updated)
-----

  trunk/channels/chan_sip.c 341805 
  trunk/channels/sip/include/sip.h 341805 

Diff: https://reviewboard.asterisk.org/r/1516/diff


Testing
-------

Ran this through a large portion of the external testsuite, but it needs quite a bit more testing before commit.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111024/7d674088/attachment-0001.htm>