[asterisk-dev] [Code Review] TestSuite: Add tagging functionality to test framework

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1537/#review4561
-----------------------------------------------------------


This is some useful functionality, but in some ways, this patch isn't actually needed.  This is really another mechanism to achieve what you can already do using the top level test-config.yaml file.

In that, you can specify tests to specifically exclude - so if you wanted to test only 'core' tests - whatever those were - you could pull out all the tests that you don't care about.  Your test-config.yaml specifies what test configuration you're going to run when you execute runtests.py, so it's about as easy to change as changing a command line option.

That's not to say that this isn't more flexible, but if all you want to run is a subset of some tests, you can technically already set that up.


asterisk/trunk/lib/python/asterisk/TestConfig.py
<https://reviewboard.asterisk.org/r/1537/#comment8740>

    Although it should never be called in this way, properties may not exist in a TestConfig instance.  A top level test-config.yaml file, for example, won't contain 'properties' at the level that this implies.
    
    I'd check for properties before accessing it here.



asterisk/trunk/runtests.py
<https://reviewboard.asterisk.org/r/1537/#comment8739>

    I would just combine this and __check_deps.  Rename it to something like __check_can_run.  No real need for two methods if all they do is delegate to two other methods in TestConfig.


- mjordan


On Oct. 21, 2011, 2:57 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1537/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2011, 2:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add the ability to tag tests with arbitrary attributes to facilitate running specific groups of tests.
> 
> 
> This addresses bug ASTERISK-18427.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18427
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/README.txt 2636 
>   asterisk/trunk/lib/python/asterisk/TestConfig.py 2636 
>   asterisk/trunk/runtests.py 2636 
> 
> Diff: https://reviewboard.asterisk.org/r/1537/diff
> 
> 
> Testing
> -------
> 
> Ensured that lack of tags in a test did not cause errors and that tags work as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111021/c2e21b08/attachment.htm>