[asterisk-dev] [Code Review]: Add some realtime SIP tests via res_config_sqlite

[mjordan]

> On Oct. 20, 2011, 2:20 p.m., mjordan wrote:
> > /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/run-test, line 17
> > <https://reviewboard.asterisk.org/r/1498/diff/1/?file=21026#file21026line17>
> >
> >     You shouldn't need this, as TestCase sets up the logger configuration
> 
> Terry Wilson wrote:
>     Shouldn't have, but did. If there were sipp warnings when running the test with ./runtest -t, it would error out with a notice that it couldn't find the logger without this line.

Well, that's no good.  Go ahead and commit it and I'll see whats going on with that.


- mjordan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1498/#review4558
-----------------------------------------------------------


On Oct. 6, 2011, 7:13 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1498/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2011, 7:13 p.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and wdoekes.
> 
> 
> Summary
> -------
> 
> Here are two realtime SIP tests that test peer matching; one uses the sipregs table, the other doesn't. It would be easy to combine the two tests since the code is almost identical, but I envision a time when the sipregs table goes away and having it as a separate test would make things easier if that were to happen.
> 
> These sipregs test will fail until the fix in r/1395 is committed.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/configs/ast1/extconfig.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/configs/ast1/res_config_sqlite.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/nosipreg.sql PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/realtime.sqlite UNKNOWN 
>   /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/sipp/uac.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_nosipregs/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_sipregs/configs/ast1/extconfig.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_sipregs/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_sipregs/configs/ast1/res_config_sqlite.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_sipregs/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_sipregs/realtime.sqlite UNKNOWN 
>   /asterisk/trunk/tests/channels/SIP/realtime_sipregs/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_sipregs/sipp/uac.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_sipregs/sipregs.sql PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/realtime_sipregs/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 2504 
> 
> Diff: https://reviewboard.asterisk.org/r/1498/diff
> 
> 
> Testing
> -------
> 
> I ran the tests against the current 1.8 branch and against the 1.8 branch with the my proposed patch to wdoekes fix  r/1395 (found at http://paste.ubuntu.com/703664/).
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111020/0861a75b/attachment.htm>