[asterisk-dev] [Code Review]: TestSuite: Add tests for codec negotiation

[mjordan]

> On Oct. 20, 2011, 1:52 p.m., mjordan wrote:
> > asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/multistream.xml, line 97
> > <https://reviewboard.asterisk.org/r/1520/diff/2/?file=21198#file21198line97>
> >
> >     Why is this optional?  I would have thought that sending two stream types we should expect a 488 at some point.
> >     
> >     If this is required, apply this comment to the other tests as well.
> 
> opticron wrote:
>     This is one of two possible correct outcomes.  Either Asterisk should throw a 488 and reject the offer or respond correctly.

What would respond correctly be in this case?  I would have thought the correct response was the 488, since we received a request with a media stream configuration we don't support.


- mjordan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1520/#review4554
-----------------------------------------------------------


On Oct. 12, 2011, 1:09 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1520/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2011, 1:09 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add codec and stream negotiation tests for varying single stream, incompatible stream, and multistream situations. This requires the changes in https://reviewboard.asterisk.org/r/1516/ to pass since it corrects several issues with how Asterisk deals with SDP.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/avt_streams.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/decline_incompat_audio.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/decline_incompat_text.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/decline_incompat_video.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/multistream.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/orderstream.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/single_audio.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/single_image.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/single_image_inverse.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/single_text.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/single_text_inverse.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/single_video.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/sipp/single_video_inverse.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/codec_negotiation/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/tests.yaml 2515 
> 
> Diff: https://reviewboard.asterisk.org/r/1520/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111020/05dce6b2/attachment.htm>