[asterisk-dev] [Code Review] Allow linking/building against an external editline library.

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1528/#review4537
-----------------------------------------------------------


Pauls issue still isn't addressed:

pkg-config --cflags returns nada because <editline/readline.h> is accessible (through the normal /usr/include).



$ grep includedir /usr/lib/pkgconfig/libedit.pc
includedir=${prefix}/include
Cflags: -I${includedir}

$ pkg-config libedit --cflags
(empty)

$ grep LIBEDIT makeopts
LIBEDIT_INCLUDE= 
LIBEDIT_LIB=-ledit -lcurses  
LIBEDIT_OBJ=


make[1]: Entering directory `/home/walter/src/asterisk-svn/main'
gcc -o cli.o -c cli.c -MD -MT cli.o -MF .cli.o.d -MP -pthread -I/home/walter/src/asterisk-svn/include   -I/usr/include/libxml2 -pipe -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -g3 -march=native  -O0  -DAST_MODULE=\"core\" 
cli.c:39:22: error: readline.h: No such file or directory

- wdoekes


On Oct. 18, 2011, 8:09 a.m., jcollie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1528/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2011, 8:09 a.m.)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> The Asterisk tarball includes a very old copy of the editline library
> that manages command line history and editing.  Fedora (and several
> other distributions) highly discourage this practice because if there
> are security problems (or even just severe bugs) in the library it can
> be very difficult to track down all instances of the library.  This
> patch adds the option of building/linking against an external copy of
> the editline library.
> 
> 
> This addresses bug ASTERISK-18725.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18725
> 
> 
> Diffs
> -----
> 
>   /trunk/build_tools/menuselect-deps.in 341072 
>   /trunk/configure UNKNOWN 
>   /trunk/configure.ac 341072 
>   /trunk/include/asterisk/autoconfig.h.in 341072 
>   /trunk/main/Makefile 341072 
>   /trunk/main/asterisk.c 341072 
>   /trunk/main/cli.c 341072 
>   /trunk/makeopts.in 341072 
> 
> Diff: https://reviewboard.asterisk.org/r/1528/diff
> 
> 
> Testing
> -------
> 
> This patch has been in use in the Fedora Asterisk packages for some time now.  Cleaning up and submitting for review.  Has been compiled and CLI editing and recall works as it's supposed to.
> 
> 
> Thanks,
> 
> jcollie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111020/a6141a2e/attachment-0001.htm>