[asterisk-dev] [Code Review] Asterisk Support of SIP Connect 1.1

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1515/#review4527
-----------------------------------------------------------


Lots of whitespace issues. Look through all of the "red blocks" and fix the trailing whitespace. I haven't looked closely enough yet at the SIP Connect stuff to talk intelligently about oej's opinion on the patch being broken up. It doesn't look to be that complex of a patch to review, though.


/trunk/include/asterisk/strings.h
<https://reviewboard.asterisk.org/r/1515/#comment8696>

    This function already exists in a weird place: pval.h and implemented in res/ael/pval.c.


- Terry


On Oct. 18, 2011, 3:11 p.m., Neeharika Allanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1515/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2011, 3:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This Chan-SIP patch brings Asterisk into compliance with the SIPconnect1.1.  SIPconnect1.1 is a newly released SIP Forum specification that describes a common set of signaling and media interworking procedures for the SIP Trunk interface between a SIP-based IP-PBX and a SIP-enabled Service Provider network. This patch, coupled with specific Asterisk configuration settings, will enable Asterisk to comply with the normative SIP-PBX requirements specified in SIPconnect1.1.
> 
> The patch diff listings being submitted are against Asterisk version 1.8.11.The patch itself has been tested against the 1.8.0 version of Asterisk for the following SIPconnect1.1 functions/capabilities:
> 
> Security
> -TLS
> -SIP Digest
> 
> Registration (RFC 6140)
> -Basic GIN registration
> -did not test the GIN interactions with the GRUU and reg-event package extensions)
> 
> Calling features
> -Basic DID/DOD calls
> -Calling name/number delivery with and without privacy
> -Early media
> -Call Forwarding
> -Call Transfer (attended and blind)
> -Emergency calls
> -DTMF relay
> 
> 
> This addresses bug ASTERISK-18705.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18705
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 333472 
>   /trunk/channels/sip/include/sip.h 333472 
>   /trunk/configs/sip.conf.sample 333472 
>   /trunk/include/asterisk/strings.h 333472 
> 
> Diff: https://reviewboard.asterisk.org/r/1515/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neeharika
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111018/8692d96d/attachment-0001.htm>