[asterisk-dev] [Code Review] Don't send in-dialog requests when Asterisk has not yet received a Contact URI from a UAS

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1531/#review4526
-----------------------------------------------------------

Ship it!


Thanks for catching this before I had a chance to ask you to look into it :-)

- Kevin


On Oct. 18, 2011, 4:37 p.m., schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1531/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2011, 4:37 p.m.)
> 
> 
> Review request for Asterisk Developers and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> after storing the route header for an update request in a early dialog (for example 180) i have found that some phones didnt sent a contact header in a 1xx response. Without this contact header we couldnt sent out an update request.
> 
> this small change checks if we have an okcontacturi and didnt sent out the update request if not.
> 
> 
> Diffs
> -----
> 
>   team/schmidts/unleash-the-beast/channels/chan_sip.c 340808 
> 
> Diff: https://reviewboard.asterisk.org/r/1531/diff
> 
> 
> Testing
> -------
> 
> test it with a cisco spa941 which didnt sent a contact header in 100 or 180 and with a cisco spa525 which sent out a contact header.
> 
> normal connected line updates work as expected.
> 
> 
> Thanks,
> 
> schmidts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111018/67d79319/attachment-0001.htm>