[asterisk-dev] [Code Review]: svnmerge: avoid a separator when merging a single commit

[Tzafrir Cohen]

> On Oct. 17, 2011, 1:38 p.m., rmudgett wrote:
> > -1
> > 
> > The separator indicates what was in the original commit message from where the commit was merged from.
> 
> Tzafrir Cohen wrote:
>     Why and where is that information required?
> 
> rmudgett wrote:
>     I like to see what was in the original commit message isolated from additions from merging.
>     It is personal preference like this change to remove it is personal preference.

It's everything besides the separate line at the end of the commit message. See http://svnview.digium.com/svn/asterisk?view=revision&revision=341198

I don't think that the original commit message needs keeping if it was actually changed - this is why I reference the original.


- Tzafrir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1530/#review4517
-----------------------------------------------------------


On Oct. 17, 2011, 2 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1530/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2011, 2 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> If a merged commit only merges a single original revision, there is no use in adding a separator (........) at the end of the commit.
> 
> 
> Diffs
> -----
> 
>   /svnmerge 804 
> 
> Diff: https://reviewboard.asterisk.org/r/1530/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111017/8f3dbb5c/attachment.htm>